Skip to content

COD-1345 #449

Merged
meichend merged 2 commits into
developmentfrom
meichendong/cod-1345-kebab-menu-isnt-shown-on-context-details
Jul 18, 2022
Merged

COD-1345 #449
meichend merged 2 commits into
developmentfrom
meichendong/cod-1345-kebab-menu-isnt-shown-on-context-details

Conversation

@meichend
Copy link
Copy Markdown
Contributor

Description

Make scope text turn into ellipsis on the left

Type of Change

  • Tech Debt (refactoring, unit tests, CI changes, pre-commit hooks, etc)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

🖖🤚

Test Configuration:

  • CCL version/branch: 1.X
  • API version/branch: 1.X

Checklist:

  • I have performed a self-review of my code
  • I have used codex to provide context, particularly in hard-to-understand areas
  • Any dependent changes have been made available in downstream modules

Screenshots:

image

@meichend meichend requested a review from derrickpersson July 15, 2022 00:01
@linear
Copy link
Copy Markdown

linear Bot commented Jul 15, 2022

COD-1345 Kebab menu isn't shown on context details page when file scope is long & view is narrow

Screen Shot 2022-07-13 at 10.14.36 AM.png

Leads to user confusion because they don't have any options about what they can do with their context (i.e. delete / copy link )

Sol'n:

Truncate inline scope starting from the left in order to show kebab menu at all times.

@derrickpersson
Copy link
Copy Markdown
Contributor

😞 Umm doesn't look like it works for shorted files unfortunately...
Screen Shot 2022-07-15 at 12 25 12 PM


.wrapper {
overflow: hidden;
margin-left: 0em;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we need the margin-left 0 here. Should already be 0?

vertical-align: middle;
text-overflow: ellipsis;
white-space: nowrap;
direction: rtl;
Copy link
Copy Markdown
Contributor

@cpul cpul Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason your filename is far off from the left is because of this direction property.
I believe what you need to do here is to rearrange the styles to get the desired effect.
Essentially, you want something like this (I'll use a basic example of the above):

<div class="context-metadata">
  <div class="context-metadata__wrapper">
    <div class="context-metadata__header"> <-- remove ellipsis stuff; make this a column-direction flexbox
      <AuthorDetails />
      <InlineScope /> <-- apply the ellipsis and direction styles to the wrapping parent element around the link here
    </div>
  </div>
</div>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chris === CSS Guru 😁

Copy link
Copy Markdown
Contributor

@derrickpersson derrickpersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 😎

@meichend meichend merged commit 4758cb8 into development Jul 18, 2022
@meichend meichend deleted the meichendong/cod-1345-kebab-menu-isnt-shown-on-context-details branch July 18, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants