Conversation
COD-1345 Kebab menu isn't shown on context details page when file scope is long & view is narrow
Screen Shot 2022-07-13 at 10.14.36 AM.png Leads to user confusion because they don't have any options about what they can do with their context (i.e. delete / copy link ) Sol'n: Truncate inline scope starting from the left in order to show kebab menu at all times. |
Contributor
|
|
||
| .wrapper { | ||
| overflow: hidden; | ||
| margin-left: 0em; |
Contributor
There was a problem hiding this comment.
Not sure we need the margin-left 0 here. Should already be 0?
cpul
reviewed
Jul 18, 2022
| vertical-align: middle; | ||
| text-overflow: ellipsis; | ||
| white-space: nowrap; | ||
| direction: rtl; |
Contributor
There was a problem hiding this comment.
The reason your filename is far off from the left is because of this direction property.
I believe what you need to do here is to rearrange the styles to get the desired effect.
Essentially, you want something like this (I'll use a basic example of the above):
<div class="context-metadata">
<div class="context-metadata__wrapper">
<div class="context-metadata__header"> <-- remove ellipsis stuff; make this a column-direction flexbox
<AuthorDetails />
<InlineScope /> <-- apply the ellipsis and direction styles to the wrapping parent element around the link here
</div>
</div>
</div>
Contributor
There was a problem hiding this comment.
Chris === CSS Guru 😁
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Make scope text turn into ellipsis on the left
Type of Change
How Has This Been Tested?
🖖🤚
Test Configuration:
Checklist:
Screenshots: