Skip to content

COD-1331 Add action item to open the context on vscode notifications #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meichend merged 3 commits into from
Jul 19, 2022
Merged

COD-1331 Add action item to open the context on vscode notifications #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e01bd5
change text when context
meichend Jul 18, 2022
1302ed3
Open context when there is one
meichend Jul 18, 2022
2d130e9
handle error
meichend Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 28 additions & 4 deletions codex-vscode/src/helpers/notifications.helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,16 @@
import * as vscode from "vscode";

import { Notification } from "@usecodex/common-library";
import { Context, Notification } from "@usecodex/common-library";
import { CodexService } from "../services/codex.service";
import { UserService } from "../services/user.service";
import { getNotificationDetails } from "./format.helper";
import { openContext } from "./goto.helper";
import { updateStatusBar } from "./misc.helper";
import { UserService } from "../services/user.service";
import { SidebarService } from "../services/sidebar.service";
import { MESSAGE_TYPES } from "../globals";

const OPEN = "Open";
const OK = "Ok";

async function handleStatusBarUpdate(): Promise<vscode.Disposable> {
const notifications = await UserService.getInstance().getNotifications();
Expand All @@ -25,9 +32,26 @@ function formatStatusBarMessage(notifications: Array<Notification>) {
}

function displayInformationMessage(notification: Notification) {
const acknowledgement = ["Ok"];
const contextId = notification.codexNotificationObject?.contextId;
const action = contextId ? OPEN : OK;
const acknowledgement = [action];
const description = getNotificationDetails(notification).title;
description && vscode.window.showInformationMessage(description, ...acknowledgement);
description &&
vscode.window.showInformationMessage(description, ...acknowledgement).then(async (selection) => {
if (selection == OPEN) {
await vscode.commands.executeCommand("workbench.view.extension.codex-sidebar-view");
try {
const codexService = new CodexService(
notification.codexNotificationObject.codexId,
UserService.getInstance()
);
const context: Context = ((await codexService.getContextService().getOneById(contextId)) as Context[])[0];
openContext(context);
} catch {
SidebarService.getInstance().postMessage(MESSAGE_TYPES.notFound, { message: "Context is not found." });
}
}
});
}

export { handleStatusBarUpdate, handleSetStatusBarMessage, formatStatusBarMessage, displayInformationMessage };
7 changes: 3 additions & 4 deletions codex-webview/src/views/pages/ContextItemPage.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,11 @@
$: contextId = parseInt($params.contextId);
$: context = $contextStore.contexts.get(contextId);

defaultCodicesStore.subscribe((defaultCodices: Codex[]) => {
codex = defaultCodices.find((codex) => context?.codexId === codex.id);
});

onMount(() => {
// TODO: Fetch context data here - COD-982
defaultCodicesStore.subscribe((defaultCodices: Codex[]) => {
codex = defaultCodices.find((codex) => context?.codexId === codex.id);
});
});

</script>
Expand Down