Skip to content

Always check for origin before fallback to first remote#452

Merged
derrickpersson merged 2 commits into
developmentfrom
derrick/cod-1375-typeerror-cannot-read-properties-of
Jul 19, 2022
Merged

Always check for origin before fallback to first remote#452
derrickpersson merged 2 commits into
developmentfrom
derrick/cod-1375-typeerror-cannot-read-properties-of

Conversation

@derrickpersson
Copy link
Copy Markdown
Contributor

Description

  • Always checking for origin before falling back to first remote.
  • Improving Sentry logging configuration / console logging.

Type of Change

  • Tech Debt (refactoring, unit tests, CI changes, pre-commit hooks, etc)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • git remote remove origin

  • git remote add <random name> <remote url>

  • Still works!

  • git remote add origin <remote url>

  • Still works!

Test Configuration:

  • CCL version/branch: 1.X
  • API version/branch: 1.X

Checklist:

  • I have performed a self-review of my code
  • I have used codex to provide context, particularly in hard-to-understand areas
  • Any dependent changes have been made available in downstream modules

Screenshots:

@derrickpersson derrickpersson requested a review from tednology July 19, 2022 18:42
@linear
Copy link
Copy Markdown

linear Bot commented Jul 19, 2022

COD-1375 TypeError: Cannot read properties of undefined (reading 'fire')

Sentry Issue: VSCODE-2QS

TypeError: Cannot read properties of undefined (reading 'fire')
  File "/home/amacgregor/.vscode/extensions/clarkio.twitch-highlighter-1.0.3/out/extension.js", line 393, col 43100, in Timeout.<anonymous>
    '{snip} *(){yield m.API.validateToken(e),this._onAuthStatusChanged.fire(!0),this.log("Twitch access token has been validated.");setInterval(this.val {snip}
  ?, in Generator.next
  File "/home/amacgregor/.vscode/extensions/clarkio.twitch-highlighter-1.0.3/out/extension.js", line 393, col 42190, in n
    '{snip} n new(a||(a=Promise))((function(r,o){function n(e){try{c(i.next(e))}catch(e){o(e)}}function s(e){try{c(i.throw(e))}catch(e){o(e)}}function c {snip}
  File "node:internal/process/task_queues", line 96, col 5, in processTicksAndRejections

Copy link
Copy Markdown
Contributor

@cpul cpul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left you some suggestions to make or discuss.

Comment thread codex-vscode/src/services/git.service.ts Outdated
Comment thread codex-vscode/src/services/git.service.ts
Comment thread codex-vscode/src/services/git.service.ts Outdated
Comment thread codex-vscode/src/services/git.service.ts Outdated
Comment thread codex-vscode/src/helpers/logging.helper.ts
@derrickpersson derrickpersson merged commit 17106b5 into development Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants