Skip to content

COD-1266 Correct notification count in VS Code bar#463

Merged
derrickpersson merged 2 commits into
developmentfrom
meichendong/cod-1266-investigate-why-notification-count-in-vs
Jul 22, 2022
Merged

COD-1266 Correct notification count in VS Code bar#463
derrickpersson merged 2 commits into
developmentfrom
meichendong/cod-1266-investigate-why-notification-count-in-vs

Conversation

@meichend
Copy link
Copy Markdown
Contributor

Description

Use the store to pass the actionable notifications to the status bar instead of fetching all notifications the user has.

Type of Change

  • Tech Debt (refactoring, unit tests, CI changes, pre-commit hooks, etc)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

👉👈
Test Configuration:

  • CCL version/branch: 1.X
  • API version/branch: 1.X

Checklist:

  • I have performed a self-review of my code
  • I have used codex to provide context, particularly in hard-to-understand areas
  • Any dependent changes have been made available in downstream modules

Screenshots:

image

@meichend meichend requested review from a team and derrickpersson and removed request for a team July 22, 2022 00:10
Copy link
Copy Markdown
Contributor

@derrickpersson derrickpersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It's definitely a weird pattern, but it's the best we can do without a large refactoring to move the state to the extension side.

@derrickpersson derrickpersson merged commit 3ae3260 into development Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants