Redundant Security Checks & Code Bloat->Replace with Modifiers

[aniket866]

• Location: payInvoice, cancelInvoice, getPaymentStatus (Repeated checks for invoiceId, msg.sender, isPaid).

• Issue : Redundant require(..) checks can be grouped in a modifier , to optimize code byte size

My Proposed Idea:

Refactor repeated require statements into reusable modifiers (e.g., validInvoice, onlyCreator, invoiceActive).

@kumawatkaran523 What's your view on this , Feel free to assign

[Sana9058]

Hi @aniket866 👋
This looks like a good refactor opportunity.

I’d like to work on this by extracting the repeated require checks into reusable modifiers (e.g. validInvoice, onlyCreator,
invoiceActive) to reduce code duplication and improve readability.

Please let me know if I can take this up.

[Sana9058]

Hi @aniket866 I’ve created a PR (#94) addressing this issue by refactoring the repeated require checks into reusable
modifiers.
The change keeps the existing logic unchanged while reducing duplication and improving readability. Please have a look when you get a chance.

Happy to make any adjustments if needed. Thanks!

[aniket866]

Hi @aniket866 I’ve created a PR (#94) addressing this issue by refactoring the repeated require checks into reusable
modifiers.
The change keeps the existing logic unchanged while reducing duplication and improving readability. Please have a look when you get a chance.

Happy to make any adjustments if needed. Thanks!

@Sana9058 have you joined discord server of this org?

[Sana9058]

Hi @aniket866 Yes, I’ve joined the Discord server. Thanks for letting me know!

[sach2004]

@kumawatkaran523 @DengreSarthak it is barely valid, the modifiers get inlined by the compiler so no gas savings, and for security critical functions having checks explicitly visible is better for auditing