[REFACTOR] Enhance minimality by removing redundant wrapper method in mempool.py

[sanaica]

Addressed Issues:

Fixes N/A (Standalone core minimality improvement)

Screenshots/Recordings:

N/A (Backend refactoring, no UI changes).

Additional Notes:

This PR is a minor cleanup to align with the project's goal of keeping the core MiniChain minimal, readable, and under the target LOC.

Changes:

• Removed the unnecessary _get_tx_id() wrapper method in mempool.py.
• Updated all internal calls to access the tx.tx_id property directly.

This removes unnecessary indirection, reduces lines of code, and makes the internal loops slightly more efficient. No consensus logic or external APIs were altered. I have tested the changes locally using the pytest suite (all 41 tests passed) to ensure standard mempool functionality remains unchanged.

AI Usage Disclosure:

We encourage contributors to use AI tools responsibly when creating Pull Requests. While AI can be a valuable aid, it is essential to ensure that your contributions meet the task requirements, build successfully, include relevant tests, and pass all linters. Submissions that do not meet these standards may be closed without warning to maintain the quality and integrity of the project. Please take the time to understand the changes you are proposing and their impact. AI slop is strongly discouraged and may lead to banning and blocking. Do not spam our repos with AI slop.

Check one of the checkboxes below:

• This PR does not contain AI-generated code at all.
• This PR contains AI-generated code. I have read the [AI Usage Policy](https://github.com/AOSSIE-Org/Info/blob/main/AI-UsagePolicy.md) and this PR complies with this policy. I have tested the code locally and I am responsible for it.
  I have used the following AI models and tools: Gemini

Checklist

• My PR addresses a single issue, fixes a single bug or makes a single improvement.
• My code follows the project's code style and conventions
• If applicable, I have made corresponding changes or additions to the documentation
• If applicable, I have made corresponding changes or additions to tests
• My changes generate no new warnings or errors
• I have joined the [Discord server](https://discord.gg/hjUhu33uAn) and I will share a link to this PR with the project maintainers there
• I have read the [Contribution Guidelines](https://www.google.com/search?q=../CONTRIBUTING.md)
• Once I submit my PR, CodeRabbit AI will automatically review it and I will address CodeRabbit's comments.
• I have filled this PR template completely and carefully, and I understand that my PR may be closed without review otherwise.

Summary by CodeRabbit

• Refactor
  • Simplified internal transaction processing logic by streamlining identifier retrieval. No user-facing functionality changes.

[coderabbitai]

Walkthrough

The change removes the private helper method _get_tx_id() from the Mempool class and replaces its invocations with direct attribute access to tx.tx_id across transaction handling methods.

Changes

Cohort / File(s)	Summary
Mempool Refactoring minichain/mempool.py	Removed private helper method _get_tx_id() and replaced all usages with direct tx.tx_id attribute access in add_transaction(), remove_transactions(), and _seen_tx_ids recomputation logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested labels

Python Lang

Poem

🐰 A wrapper falls away,
Direct paths now light the day,
tx.tx_id shines so bright,
Simpler code, a cleaner sight!

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main refactoring change: removing a redundant wrapper method to enhance code minimality in mempool.py.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[SIDDHANTCOOKIE]

@sanaica this is already done in a much better way in #70 please check the prs to avoid duplicate effort

[sanaica]

@sanaica this is already done in a much better way in #70 please check the prs to avoid duplicate effort

Hey!
My bad, @SIDDHANTCOOKIE
Missed the PR 70 in queue while trying to fix things at my end.
The O(1) is a much better way to handle it.
Thanks for pointing it out, have a nice day! Closing this one to keep things clean.