Skip to content

Use correct counter name for RPS metrics #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deanward81 merged 3 commits into from
Jan 5, 2022
Merged

Use correct counter name for RPS metrics #43

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
007a915
Use correct counter name for RPS metrics
xsoheilalizadeh Dec 10, 2021
e8fb269
Use correct runtime units
xsoheilalizadeh Dec 13, 2021
7697ab3
Revert "Use correct runtime units"
xsoheilalizadeh Dec 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/StackExchange.Metrics/Metrics/AspNetMetricSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ void AddGaugeCallback(string eventName, string name, string unit, string descrip
diagnosticsCollector.AddGaugeCallback(MicrosoftAspNetCoreHostingEventSourceName, eventName, gauge.Record);
}

AddCounterCallback("requests-per-sec", "dotnet.kestrel.requests.per_sec", "requests/sec", "Requests per second");
AddCounterCallback("requests-per-second", "dotnet.kestrel.requests.per_sec", "requests/sec", "Requests per second");
AddGaugeCallback("total-requests", "dotnet.kestrel.requests.total", "requests", "Total requests");
AddGaugeCallback("current-requests", "dotnet.kestrel.requests.current", "requests", "Currently executing requests");
AddGaugeCallback("failed-requests", "dotnet.kestrel.requests.failed", "requests", "Failed requests");
Expand Down