Fix TaggedMetricFactory constructor params order

[g3rv4]

All the implementers end up calling : base(name, unit, description, options), but the constructor's param order requires name, description, unit, options.

As the API exposes the same interface, I think it's better to keep it consistent:

Here you can see the 5 usages of this constructor:

StackExchange.Metrics/src/StackExchange.Metrics/Infrastructure/TaggedMetricFactory.Generated.cs

Lines 75 to 82 in e707564

	public abstract class TaggedMetricFactory<TMetric, TTag1> : TaggedMetricFactory<TMetric> where TMetric : MetricBase
	{
	private readonly TaggedMetricDictionary<TTag1> _metrics = new TaggedMetricDictionary<TTag1>();
	/// <summary>
	/// Initializes the base class
	/// </summary>
	protected TaggedMetricFactory(string name, string unit, string description, MetricSourceOptions options, in MetricTag<TTag1> tag1) : base(name, unit, description, options)

StackExchange.Metrics/src/StackExchange.Metrics/Infrastructure/TaggedMetricFactory.Generated.cs

Lines 323 to 330 in e707564

	public abstract class TaggedMetricFactory<TMetric, TTag1, TTag2> : TaggedMetricFactory<TMetric> where TMetric : MetricBase
	{
	private readonly TaggedMetricDictionary<(TTag1 Tag1, TTag2 Tag2)> _metrics = new TaggedMetricDictionary<(TTag1 Tag1, TTag2 Tag2)>();
	/// <summary>
	/// Initializes the base class
	/// </summary>
	protected TaggedMetricFactory(string name, string unit, string description, MetricSourceOptions options, in MetricTag<TTag1> tag1, in MetricTag<TTag2> tag2) : base(name, unit, description, options)

StackExchange.Metrics/src/StackExchange.Metrics/Infrastructure/TaggedMetricFactory.Generated.cs

Lines 578 to 585 in e707564

	public abstract class TaggedMetricFactory<TMetric, TTag1, TTag2, TTag3> : TaggedMetricFactory<TMetric> where TMetric : MetricBase
	{
	private readonly TaggedMetricDictionary<(TTag1 Tag1, TTag2 Tag2, TTag3 Tag3)> _metrics = new TaggedMetricDictionary<(TTag1 Tag1, TTag2 Tag2, TTag3 Tag3)>();
	/// <summary>
	/// Initializes the base class
	/// </summary>
	protected TaggedMetricFactory(string name, string unit, string description, MetricSourceOptions options, in MetricTag<TTag1> tag1, in MetricTag<TTag2> tag2, in MetricTag<TTag3> tag3) : base(name, unit, description, options)

StackExchange.Metrics/src/StackExchange.Metrics/Infrastructure/TaggedMetricFactory.Generated.cs

Lines 840 to 847 in e707564

	public abstract class TaggedMetricFactory<TMetric, TTag1, TTag2, TTag3, TTag4> : TaggedMetricFactory<TMetric> where TMetric : MetricBase
	{
	private readonly TaggedMetricDictionary<(TTag1 Tag1, TTag2 Tag2, TTag3 Tag3, TTag4 Tag4)> _metrics = new TaggedMetricDictionary<(TTag1 Tag1, TTag2 Tag2, TTag3 Tag3, TTag4 Tag4)>();
	/// <summary>
	/// Initializes the base class
	/// </summary>
	protected TaggedMetricFactory(string name, string unit, string description, MetricSourceOptions options, in MetricTag<TTag1> tag1, in MetricTag<TTag2> tag2, in MetricTag<TTag3> tag3, in MetricTag<TTag4> tag4) : base(name, unit, description, options)

StackExchange.Metrics/src/StackExchange.Metrics/Infrastructure/TaggedMetricFactory.Generated.cs

Lines 1109 to 1116 in e707564

	public abstract class TaggedMetricFactory<TMetric, TTag1, TTag2, TTag3, TTag4, TTag5> : TaggedMetricFactory<TMetric> where TMetric : MetricBase
	{
	private readonly TaggedMetricDictionary<(TTag1 Tag1, TTag2 Tag2, TTag3 Tag3, TTag4 Tag4, TTag5 Tag5)> _metrics = new TaggedMetricDictionary<(TTag1 Tag1, TTag2 Tag2, TTag3 Tag3, TTag4 Tag4, TTag5 Tag5)>();
	/// <summary>
	/// Initializes the base class
	/// </summary>
	protected TaggedMetricFactory(string name, string unit, string description, MetricSourceOptions options, in MetricTag<TTag1> tag1, in MetricTag<TTag2> tag2, in MetricTag<TTag3> tag3, in MetricTag<TTag4> tag4, in MetricTag<TTag5> tag5) : base(name, unit, description, options)

[deanward81]

👍