This repository was archived by the owner on Jan 22, 2022. It is now read-only.
Modified "CreateQuery" #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added anonymous struct support for "CreateQuery". It now accepts a optional variadic "class" parameter. So you can pass the wmi class name when your struct is anonymous and has no name or your struct is not named like the wmi class.
Moe-Kite
approved these changes
Mar 31, 2020
Moe-Kite
left a comment
Moe-Kite
left a comment
There was a problem hiding this comment.
That would be a great addition, some WMI classes have a name that is incompatible with golint standard (implementing Effective Go rules), mainly no underscore in type name rule.
Contributor
|
Sadly the original creators of this module are no longer with Stack Overflow, but I feel that the change looks low-risk and is safe to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added anonymous struct support for "CreateQuery". It now accepts a optional variadic "class" parameter.
So you can pass the wmi class name when your struct is anonymous and has no name or your struct is not named like the wmi class.