Ensure log file path is configured before logging errors#109
Merged
thatarchguy merged 1 commit intodevelopmentfrom Apr 3, 2016
Merged
Ensure log file path is configured before logging errors#109thatarchguy merged 1 commit intodevelopmentfrom
thatarchguy merged 1 commit intodevelopmentfrom
Conversation
* Now checks if the log file path is defined before writing errors to the log file * Moves the log file outside of the Blueprint and into postmaster.utils
| user. It then appends it with an ISO 8601 UTC timestamp to a JSON formatted log file | ||
| """ | ||
| log_path = models.Configs.query.filter_by(setting='Log File').first().value | ||
| if log_path and ((category == 'error') or |
Member
Author
There was a problem hiding this comment.
This if statement is what fixed the potential issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the log file