Stackstorm_aws problems with python3 #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In python 3 dict.items() return an iterator instead of the complete list of items. This means that when `del kwargs[k]` will result in a `RuntimeError: dictionary changed size during iteration` error.
Update action.py to use python 3 compatible iterator
nmaludy
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in the changes performed under #103 by jamison-rose and also the suggested fix under: #104
Addressed review comments for pack.yaml and CHANGES.md changes.
I tried to add a unit-test but I'm not sure if the current mocks bypass the calls, as the problems appear in the do_method of the actions/lib/action.py