Address problems with ec2 start and stop aliases #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmaludy
suggested changes
Apr 30, 2020
Contributor
nmaludy
left a comment
nmaludy
left a comment
There was a problem hiding this comment.
Looks good.
Can you please add a CHANGELOG entry and bump the pack version by 0.0.1 (bug fix)
Contributor
Author
Contributor
Author
|
@nmaludy I think I 've addressed your comments. |
nmaludy
approved these changes
May 14, 2020
Contributor
nmaludy
left a comment
nmaludy
left a comment
There was a problem hiding this comment.
Thank you very much for the contribution!
Contributor
|
@amanda11 got this merged in, for #103 just need @jamison-rose to update the PR with a few changes. If you want, you could create your own PR with those same changes and potentially get it merged in sooner. |
Contributor
Author
|
@nmaludy Thanks. Happy to produce a PR with the other changes needed for python3, but will probably be next week until I get a chance. But I'll aim to get something up to close off those two python3 problems with the pack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ec2 start and stop aliases to use InstanceIds parameter to match action, amend result handling and add unit-test.
Addresses: #98