Skip to content

Conversation

@obynio
Copy link
Contributor

@obynio obynio commented Jan 6, 2022

Thanks for your reply @armab, here is the PR you asked me about.

This PR fixes #71 by upgrading the lxml dependency.
Installation of the pack on Ubuntu 20 was successful and I was able to run actions and send messages to Slack.

Changelog

  • Upgrade lxml dependency from 3.8.0 to 4.6.5

@obynio obynio requested review from a team, Kami and nmaludy as code owners January 6, 2022 17:18
@arm4b
Copy link
Member

arm4b commented Jan 6, 2022

From the CI failure https://github.com/StackStorm-Exchange/stackstorm-slack/runs/4729962031:

sensors/slack_sensor.py:4:0: E0401: Unable to import 'slackclient' (import-error)

Something changed between the major slack versions.

@arm4b
Copy link
Member

arm4b commented Jan 6, 2022

Looks like the sensor here https://github.com/StackStorm-Exchange/stackstorm-slack/blob/master/sensors/slack_sensor.py is the only file that really uses slackclient.

Everything else is just a direct HTTP API call via requests https://github.com/StackStorm-Exchange/stackstorm-slack/blob/master/actions/run.py and so doesn't depend on slackclient from pip.

If you don't want to rewrite the entire slack sensor with the new API, I think just bumping the slackapi to latest 1.x version should pass the CI and be something working to merge the PR today.

If anyone will be willing to update the sensor, - probably it's best to do in the future PR.

@arm4b arm4b added dependencies Pull requests that update a dependency file enhancement labels Jan 6, 2022
@obynio
Copy link
Contributor Author

obynio commented Jan 7, 2022

Thanks for your review @armab for the moment let's just upgrade the lxml dependency so that the package can work on Ubuntu 20 👍

@arm4b arm4b changed the title Upgrade lxml to 4.6.5 and slackclient to 2.9.3 Upgrade lxml to 4.6.5 Jan 7, 2022
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! 👍

- messaging
- instant messaging
version: 2.0.5
version: 2.1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also updated the version here.
Otherwise, new pack won't be released.

@arm4b arm4b merged commit ec94e61 into StackStorm-Exchange:master Jan 7, 2022
@obynio obynio deleted the obynio/upgrade-deps branch January 9, 2022 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slack pack won't install on python 3.8

2 participants