-
Notifications
You must be signed in to change notification settings - Fork 32
Upgrade lxml to 4.6.5 #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
From the CI failure https://github.com/StackStorm-Exchange/stackstorm-slack/runs/4729962031: Something changed between the major slack versions. |
|
Looks like the sensor here https://github.com/StackStorm-Exchange/stackstorm-slack/blob/master/sensors/slack_sensor.py is the only file that really uses Everything else is just a direct HTTP API call via If you don't want to rewrite the entire slack sensor with the new API, I think just bumping the slackapi to latest 1.x version should pass the CI and be something working to merge the PR today. If anyone will be willing to update the sensor, - probably it's best to do in the future PR. |
|
Thanks for your review @armab for the moment let's just upgrade the lxml dependency so that the package can work on Ubuntu 20 👍 |
arm4b
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! 👍
| - messaging | ||
| - instant messaging | ||
| version: 2.0.5 | ||
| version: 2.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also updated the version here.
Otherwise, new pack won't be released.
Thanks for your reply @armab, here is the PR you asked me about.
This PR fixes #71 by upgrading the
lxmldependency.Installation of the pack on Ubuntu 20 was successful and I was able to run actions and send messages to Slack.
Changelog