Action tests #19
Merged
Action tests #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cognifloyd
force-pushed
the
action_tests
branch
from
880df9f to
e8a95e7
Compare
Member
Author
|
I dropped 2.7 tests due to: StackStorm/community#40 (comment) 3.6 tests are failing because StackStorm-Exchange/ci#101 hasn't been merged yet. |
Since the 2.7 job was dropped, we need to save things in the 3.6 job so that it is available during the deploy step. Also add some safety bits that are in the StackStorm-Exchange/ci and should eventually go to all packs.
In [1] the default path was changed from ${HOME}/bin to
${HOME}/.local/bin which is compatible with both CI and local
development, so drop the hacky workaround.
[1] hvac/hvac@56ade59
cognifloyd
force-pushed
the
action_tests
branch
from
41d5e8f to
c8760f6
Compare
nmaludy
suggested changes
Feb 3, 2021
We still have to have two calls, because HvacIntegrationTestCase does not call super(). However, we can call super() for it, so do that instead of the old manual method.
cognifloyd
commented
Feb 3, 2021
Member
Author
cognifloyd
left a comment
cognifloyd
left a comment
There was a problem hiding this comment.
Fascinating. I wasn't sure how to deal with calling super() when one of the parents didn't also call super(). Still using super(SuperCallLessClass, self) is a nicer work around. I've pushed the changes and adjusted the comments to help future me understand what's going on.
blag
suggested changes
Feb 4, 2021
Contributor
blag
left a comment
blag
left a comment
There was a problem hiding this comment.
One small mistake needs to be fixed.
Co-authored-by: blag <blag@users.noreply.github.com>
blag
approved these changes
Feb 4, 2021
Contributor
blag
left a comment
blag
left a comment
There was a problem hiding this comment.
Awesome, thanks for taking this on!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for all actions.
To do this, we reuse the hvac testing infra to setup consul/vault for our tests.
Also, we drop the broken python2.7 tests and update the CI config to use the latest from StackStorm-Exchange/ci.
This depends onThis demonstrates how StackStorm-Exchange/ci#101 will behave by running thesetup_testing_env.shscript immediately followingdependencies.