Change from cookie to header based auth for vSphere REST APIs

[dsbibby]

Cookie based authentication is deprecated - see VMware KB 78315

This PR changes to use header based authentication instead an in doing so addresses #83 and fixes #87

[bishopbm1]

Thank you for the PR!

Will you please update and add some tests to https://github.com/StackStorm-Exchange/stackstorm-vsphere/blob/master/tests/test_action_vmwarelib_tagging.py for the changes.

Also please add a section to the Change log and update the version in the pack.yaml

Thank you!

[bishopbm1]

We had another company confirm and test for vsphere 7 and we testing on vsphere 6 and everything is working as expected. Ready to merge as soon as unit tests and other items are added.

[dsbibby]

Hi, I've been having a look at the existing tests trying to get my head around them. Any pointers/tips greatly received!

The only thought I had so far about this is that unless I'm missing something, it looks like there is no test for the login method at present. As such should the unit tests really be raised under a separate PR to validate the current code behavior. Then this PR could be validated using those tests?

Also, could consider using vcsim as part of the unit testing? I'm not sure if it would fit in to the current test framework or not.

[dsbibby]

Hi, I've been having a look at the existing tests trying to get my head around them. Any pointers/tips greatly received!

The only thought I had so far about this is that unless I'm missing something, it looks like there is no test for the login method at present. As such should the unit tests really be raised under a separate PR to validate the current code behavior. Then this PR could be validated using those tests?

Also, could consider using vcsim as part of the unit testing? I'm not sure if it would fit in to the current test framework or not.

[bishopbm1]

@dsbibby I added a test for the login method. You are correct that there were not tests on it originally. I had to make an update to fix the CircleCi workflow but we have switched this pack to GitHub Actions. I will be switching that back and updating the ChangeLog and Pack yaml so that we can get this merged.

Please review the changes that I made to the PR and let me know if you have any questions about the changes that I made or would like me to explain anything further. I am in the StackStorm Slack channel also if that is easier!

[bishopbm1]

LGTM