Add npm-shrinkwrap.json #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arm4b
approved these changes
Jan 10, 2020
Member
arm4b
left a comment
arm4b
left a comment
There was a problem hiding this comment.
I have no idea either if that'll help StackStorm/st2chatops#135 or not.
But let's try, thanks for the effort 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure it's appropriate for a dependency like this should include an
npm-shrinkwrap.jsonfile, but this PR adds a production dependency lock file so projects that depend on this package don't install our devDependencies.I also bumped the version number and add a changelog entry. Will push a release to NPM once this is reviewed and merged.
Will help StackStorm/st2chatops#135.
Commands:
rm -rf node_modules npm install --production npm shrinkwrap --production # <-- MUST include --production