Skip to content

Conversation

@batk0
Copy link

@batk0 batk0 commented Jan 19, 2019

It's simple fix of the following issue

This workflow returns TypeError: The value of "s) %>" is not type of list. because "domains" contains 'in'

version: 1.0

input:
  - domains

tasks:
  sk_update_domains:
    with:
      items: <% ctx(domains) %>
      concurency: 2
    action: i371.sk_update_domain domain=<% item() %>

@codecov-io
Copy link

codecov-io commented Jan 19, 2019

Codecov Report

Merging #117 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #117   +/-   ##
=======================================
  Coverage   94.03%   94.03%           
=======================================
  Files          38       38           
  Lines        2446     2446           
  Branches      493      493           
=======================================
  Hits         2300     2300           
  Misses         85       85           
  Partials       61       61
Impacted Files Coverage Δ
orquesta/specs/native/v1/models.py 97.63% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60a5e35...f03f3f2. Read the comment docs.

Copy link
Member

@nmaludy nmaludy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great if we had some test cases for this.

Copy link
Member

@nmaludy nmaludy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Kami
Copy link
Member

Kami commented Jan 19, 2019

Thanks for your contribution.

Great catch, indeed 👍

@m4dcoder
Copy link
Collaborator

Great catch!

@m4dcoder m4dcoder merged commit 5da6295 into StackStorm:master Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants