Fixed major version of ujson to 1.x because next major release of it won't get along with current orquesta. #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…won't get along with current orquesta. This is a workaround to avoid serialize error when deepcopy() (which is implemented in orquesta/utils/jsonify.py) with passing task object (which is generated by Conductor.get_task()) is called.
Member
Author
|
#194 solves the problem that this PR's workaround try to do, in a better way. So, I'll close this PR after it would be merged. |
Member
Author
|
I appreciate for your review. |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround of (#192) to avoid serialize error when deepcopy() which is passed task object (which is generated by Conductor.get_task()) is called.