Skip to content

Conversation

@amanda11
Copy link
Contributor

@amanda11 amanda11 commented Sep 16, 2021

Use Jinja sandboxed environment, so that any templates that attempt to access insecure code will be rejected.

Copy link
Collaborator

@m4dcoder m4dcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Do we need to update the Jinja version to >= 2.11 in requirements.txt?
  • Can you also update description of this PR on why we are using sandboxed environment
  • Please add a changelog entry.
  • The CI weren't building because workflows was automatically disabled by Github due to inactivity. I believe there's a build failure that need to be fixed.ding because workflows was automatically disabled by Github due to inactivity. It's resolved now. But I believe there's an unrelated build failure that need to be fixed.

@amanda11
Copy link
Contributor Author

  • Do we need to update the Jinja version to >= 2.11 in requirements.txt?
  • Can you also update description of this PR on why we are using sandboxed environment
  • Please add a changelog entry.
  • The CI weren't building because workflows was automatically disabled by Github due to inactivity. I believe there's a build failure that need to be fixed.ding because workflows was automatically disabled by Github due to inactivity. It's resolved now. But I believe there's an unrelated build failure that need to be fixed.

@m4dcoder Addressed your review comments (stealing the sphinx change from your PR!)

Copy link
Collaborator

@m4dcoder m4dcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@m4dcoder m4dcoder merged commit 219f00d into master Sep 17, 2021
@m4dcoder m4dcoder deleted the use_sandbox branch September 17, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants