Use hacking fork as dependency and align modules with stackstorm core. #266
Conversation
nzlosh
force-pushed
the
st2v39_compat
branch
2 times, most recently
from
8a7d867 to
bc8df70
Compare
| twine | ||
| unittest2 | ||
| # 202404: Use forked version for flake8 v7.0.0 to align requirements with st2 test-requirements | ||
| hacking @ git+https://github.com/nzlosh/hacking@flake8v7 |
There was a problem hiding this comment.
Oh. I see it in the old requirements.
Could you submit your branch as an upstream PR?
There was a problem hiding this comment.
I can. In the mid-term I think we should drop hackingcompletely. I'm not sure how likely upstream will be to accept the version bump as OpenStack components rely on hacking and flake8 v7 has breaking changes, of which I have no idea if it'll impact their code base or not. We could move the fork into the StackStorm organisation and pull from there until we have time to address the use of hacking?
There was a problem hiding this comment.
What value does hacking provide? I'm inclined to just disable it.
There was a problem hiding this comment.
It provides a set of openstack coding style checks. https://docs.openstack.org/hacking/latest/user/hacking.html#styleguide. I assume that these guidelines are used in St2 as a result of its heritage.
There was a problem hiding this comment.
hacking is only used for the orquesta repo. Looking through the list of things it enforces, I don't like this one:
- [H301] Do not import more than one module per line (*)
There was a problem hiding this comment.
But whatever. It's not worth the hassle of moving it to another org. Approved.
3 participants
This set of patches is required as part of the updates needed to support py3.8, py3.9 and py3.10. This PR is a blocking dependency for StackStorm/st2#6157