Support for API Keys based pack install and k/v setup, pack versioning, centos8 fixes, add validate_output_schema option, refactoring #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishopbm1
requested changes
Nov 26, 2021
Collaborator
bishopbm1
left a comment
bishopbm1
left a comment
There was a problem hiding this comment.
This looks awesome. I would love to see something in the Readme explaining how an API key can be used vs the standard username password.
nmaludy
suggested changes
Nov 29, 2021
cleaner way for handling apikey in kv cmd Co-authored-by: Nick Maludy <nmaludy@gmail.com>
better selinux policycoreutils package handling in CentOS 8 Co-authored-by: Nick Maludy <nmaludy@gmail.com>
Add trailing comma Co-authored-by: Nick Maludy <nmaludy@gmail.com>
Member
Author
|
@nmaludy @bishopbm1 Thanks for the reviews. I have made the requested changes and added the docs for using API Keys in README. |
Member
Author
|
@nmaludy @bishopbm1 @armab Can we get some eyes on this PR? |
nmaludy
reviewed
Jan 10, 2022
| /ci/ | ||
| Puppetfile.lock | ||
| *.pyc | ||
| .vscode/ No newline at end of file |
Member
There was a problem hiding this comment.
FYI if you want this change to stick, need to add it to .sync.yml here: https://github.com/StackStorm/puppet-st2/blob/master/.sync.yml#L2
nmaludy
approved these changes
Jan 10, 2022
bishopbm1
pushed a commit
to EncoreTechnologies/puppet-st2
that referenced
this pull request
May 20, 2022
Support for API Keys based pack install and k/v setup, pack versioning, centos8 fixes, add validate_output_schema option, refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support for installation of packs and K/V using API Keys as auth method, while also allowing to fix a version of the pack to be installed
It adds a flag to enable/disable validate_output_schema in st2.conf
It also fixes a few bugs while running in CentOS (Stream) 8 and refactors some old style code.
Closes #338
Closes #334