Set stty size

[warrenvw]

Without this change, in the stackstorm container stty size returns 0 0 and potentially only part of the terminal window is used. Use stty to set the actual number of cols and rows so the entire terminal window is available for use.

[arm4b]

The code change is not so obvious for me to understand it quick. Might need a few code comments what code does and why.

On a side note, maybe setting env TERM=xterm may help in a Dockerfile?
usually fixes several Docker problems like that

[warrenvw]

I built an image with ENV TERM xterm added to the Dockerfile, and removed entrypoint.d/sttysize.sh. Connecting to the container, stty size still returns 0 0 and as above, only the first 24 rows and 80 cols of the terminal are used.

With the fix in commit 4966244, the entire terminal is used. However, I'll continue looking for a simpler solution. If none is available, then I'll document the changes or choose not to merge.

[arm4b]

👍

Looks good to me. As said before, just would be good to include a few code comments, since the impact of the change is not obvious.

And thanks for trying alternatives.

[vutny]

This is very interesting...
But I never encountered any issues with terminal size in stackstorm container, neither locally nor over SSH.

Could it be a problem of older Docker or some terminal app? I always use docker-compose exec stackstorm bash to enter the container.