Skip to content

Honor docker-compose exit codes #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arm4b merged 8 commits into from
Oct 6, 2022
Merged

Honor docker-compose exit codes #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
51f5d92
Honor docker-compose exit codes
mamercad Oct 5, 2022
e47fca4
Try `docker-compose run`
mamercad Oct 6, 2022
28ea913
Add this branch
mamercad Oct 6, 2022
7b3d577
Whoops
mamercad Oct 6, 2022
0ae8918
Switch service
mamercad Oct 6, 2022
952e808
Remove dead code and dev branch
mamercad Oct 6, 2022
75c3570
Bump Python to 3.8.10
mamercad Oct 6, 2022
98b818f
Update tests/st2tests.sh with the correct python version in the comments
arm4b Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/st2-docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:

docker-compose-up:
runs-on: ubuntu-latest
needs: [docker-compose-lint]
steps:
- uses: actions/checkout@v3

Expand All @@ -32,14 +33,18 @@ jobs:
run: |
docker-compose up --detach

- name: Run st2 smoke-tests
- name: Sleep
run: |
sleep 60
docker-compose -f tests/st2tests.yaml up

- name: Run st2 smoke-tests
run: |
docker-compose --file tests/st2tests.yaml run st2test

- name: Troubleshooting the build failure
if: ${{ failure() }}
run: |
docker-compose ps
# Display logs to help troubleshoot build failures, etc
docker-compose logs --tail="500" st2api
exit 1
4 changes: 2 additions & 2 deletions tests/st2tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ load "${BATS_HELPERS_DIR}/bats-file/load.bash"
@test 'st2 version deployed and python env are as expected' {
run st2 --version
assert_success
# st2 3.3dev (9ea417346), on Python 3.6.9
# st2 3.7.0, on Python 3.8.10
assert_line --partial "st2 ${ST2_VERSION}"
assert_line --partial 'on Python 3.6.9'
assert_line --partial 'on Python 3.8.10'
}

@test 'ST2_AUTH_URL service endpoint is accessible and working' {
Expand Down