St2web - Resolve upstream hosts every second #30
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry second and not just during the nginx startup
Merged
Contributor
Author
|
Converted the PR to draft as this has impact to k8s setups. See also: https://stackstorm-community.slack.com/archives/CCCNZUGUA/p1589111953039600 |
Contributor
Author
|
Given the progress on #28 it's safe to close this PR as it's no longer useful and a much better solution is already on it's way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #29. The new patch files update the nginx configuration in the st2web container so that the upstream hosts will be resolved every second and not just during the nginx startup.
See #28 (comment) to see in detail what it looks like without the fix applied. The nginx won't be able to connect to the upstream hosts after a change of the IP address.
Fixes: #29