Remove st2resultstracker and Enterprise mentions #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arm4b
changed the title
arm4b
reviewed
Nov 5, 2020
arm4b
suggested changes
Nov 5, 2020
Member
There was a problem hiding this comment.
Thanks for PR!
Yes, in every situation having 2 logically separated changes is ideal to solve in different PR, but OK for this time considering it's a tiny one-liner diff.
Before we remove st2resultstracker from the images, looks like it's used in https://github.com/StackStorm/st2-docker/blob/master/docker-compose.yml#L150. Worth removing those first before we could merge this one.
Co-authored-by: Eugen C. <github@armab.io>
Contributor
Author
|
Oh, of course! That's why I feel all day like I missed something. Edit: StackStorm/st2-docker#204 removes the st2resultstracker from the docker-compose file and is meant to be merged first. |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the st2resultstracker container and EWC/Enterprise is no longer mentioned on the welcome banner.
I hope it's ok to address both issues due to the small changes in a single PR.
close #39
close #32