Default connection settings in mistral.conf #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
lgtm. |
Contributor
|
+1. awesome @armab |
Member
Author
There was a problem hiding this comment.
Guys, keep in mind: I have no idea what I'm doing, since it's mistral.
For example we use it for testing, but how bad could be this setting for default installation?
Member
Author
There was a problem hiding this comment.
Ok, found it's used for OpenStack only:
https://pypi.python.org/pypi/mistral#configuring-mistral
Merging.
arm4b
pushed a commit
that referenced
this pull request
Jan 26, 2016
Default connection settings in mistral.conf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently user should generate mistral config by hand, adjusting
rabbitmqandpostgresqlconfiguration.And we do the same via our smoke tests:
Let's place mistral config with default connection, assuming everything is local, removing one step for 80% of users to make it minimally working.
Since mistral config is managed by packaging, once user change default config - it won't be replaced automatically during package upgrade, what is perfectly nice.