Skip to content

Conversation

@ZacharyPuls
Copy link

Allow for different usernames and group names, allow for spaces in both username and group name.

E.g.
20180620T110239-0500 chown: invalid group: ‘zpuls@kfn.local:zpuls@kfn.local
20180620T110239-0500 ############### ERROR ###############
20180620T110239-0500 # Failed on Configure st2 CLI config #
20180620T110239-0500 #####################################

When the user is "zpuls@kfn.local" and group is "domain users@kfn.local".

Allow for different usernames and group names, allow for spaces in both username and group name.

E.g.
20180620T110239-0500 chown: invalid group: ‘zpuls@kfn.local:zpuls@kfn.local’
20180620T110239-0500 ############### ERROR ###############
20180620T110239-0500 # Failed on Configure st2 CLI config #
20180620T110239-0500 #####################################

When the user is "zpuls@kfn.local" and group is "domain users@kfn.local".
Actually edit the template this time.
Actually edit the template this time.
Actually edit the template this time.
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposal/fix,

However we're re-working installer to fully rely on st2 login -w functionality, instead of creating CURRENT_USER_CLI_CONFIG_DIRECTORY and st2 config files manually via scripting.

See #563, #520 and StackStorm/st2#4173 for more context.

@ZacharyPuls Would be glad to hear your feedback in StackStorm/st2#4173, keeping in mind chown context.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@nzlosh
Copy link
Contributor

nzlosh commented Jan 29, 2024

Closing as stale.

@nzlosh nzlosh closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants