Adding orchestra runner to requirements #569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigmstone
force-pushed
the
orchestra-runner-install
branch
from
67bcf37 to
b66303e
Compare
enykeev
approved these changes
Jun 28, 2018
Kami
reviewed
Jun 28, 2018
|
|
||
| install_orchestra_runner() { | ||
| echo "Installing orchestra runner" | ||
| (cd /opt/stackstorm/runners/orchestra_runner; /opt/stackstorm/virtualenv/python setup.py install) |
Member
There was a problem hiding this comment.
Hm, shouldn't this path be /opt/stackstorm/st2/bin/python and not /opt/stackstorm/virtualenv/python?
Member
There was a problem hiding this comment.
Also, I wonder how this "double installation" will affect things (well, in theory we don't really double install them now, we just mess with the PYTHONPATH, but end result is similar).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.