Adding Orchestra Runner To Build #572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4dcoder
approved these changes
Jun 28, 2018
Contributor
m4dcoder
left a comment
m4dcoder
left a comment
There was a problem hiding this comment.
It works then it's good for me.
blag
previously requested changes
Jun 28, 2018
Contributor
blag
left a comment
blag
left a comment
There was a problem hiding this comment.
Remove the .swp file but otherwise 👍
bigmstone
force-pushed
the
install-runners
branch
from
ce92478 to
306b826
Compare
Kami
reviewed
Jun 29, 2018
| pip wheel --wheel-dir=$(WHEELDIR) --find-links=$(WHEELDIR) -r requirements.txt | ||
| touch $@ | ||
|
|
||
| .build-runners: |
Kami
reviewed
Jun 29, 2018
| st2exporter | ||
| st2debug | ||
| st2tests | ||
| stackstorm-runner-orchestra |
Member
There was a problem hiding this comment.
Eventually, when st2 code changes are in place, we should do the same with all the runners.
We can also do it dynamically inside inject-deps Make target, similar as we do for st2client.
This was referenced Jun 29, 2018
Member
|
Awesome! @bigmstone Thanks for digging in and going this path 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building runner wheels and adding orchestra runner to install requirements