Add bind-utils package to EL7 because linux.dig #619
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm suggesting that the bind-utils package is added on EL7 installs since it's needed for the linux.dig package, which is installed by default. Since it's a default package, it's not clearly noticeable that there is a readme and the linux.dig won't fail until the user tries to run it.
arm4b
suggested changes
Jul 2, 2019
Member
There was a problem hiding this comment.
Thanks for the contribution 👍
We've had chat about something like this in past.
From one point, linux pack is part of the core and ideally to install the dependencies needed for it to work properly. From the other side, someone would prefer to keep it minimal or don't use linux pack as well as don't bring additional dependencies.
I think I'm fine if we list all the dependencies for better user experience.
To make this PR complete, let's please add the following:
- list all the package dependencies that
linuxpack may rely on (from https://github.com/StackStorm/st2/tree/master/contrib/linux/actions) - include dependencies for both rpm and deb manifests (packages might have different names)
I just hope EL6, EL7, EL8 have no diff in naming for the packages we'll need. Same for U14,16,18.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm suggesting that the bind-utils package is added on EL7 installs since it's needed for the linux.dig package, which is installed by default. Since it's a default package, it's not clearly noticeable that there is a readme and the linux.dig won't fail until the user tries to run it.