Remove EL6 from the scripted installer, stop CircleCI builds #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eorochena
force-pushed
the
master
branch
2 times, most recently
from
4a04379 to
4ba173e
Compare
arm4b
suggested changes
Jul 1, 2020
Member
There was a problem hiding this comment.
Thanks a lot for your contribution and help removing EL6!
As I understand in this PR we're covering the following sub-tasks from the StackStorm/community#39
- update scripted installer to remove EL6 support
- stop the EL6 build in CircleCI
I updated the original PR description and also provided more feedback in the comments below.
Please also adjust the list of OS supported platforms here:
st2-packages/scripts/st2_bootstrap.sh
Lines 155 to 158 in 5d92c25
arm4b
changed the title
24 tasks
Contributor
Author
|
@armab I have implemented or the necessary changes to the PR also all CI checks have passed,. Thanks for the suggestions. |
arm4b
approved these changes
Jul 2, 2020
Member
arm4b
left a comment
arm4b
left a comment
There was a problem hiding this comment.
Looks good, thanks for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed EL6 from the scripted installer and stop EL6 builds in CIrcleCI, following StackStorm/community#39
This PR doesn't cover
rpmadjustments andst2pythonremoval related to EL6 packaging.