Skip to content

Conversation

@amanda11
Copy link
Contributor

@amanda11 amanda11 commented Jul 31, 2020

Removal of postgres and mistral on all platforms from bash one-line installer.

Addresses scripted installer of StackStorm/st2#4762

Covers removal of installation of mistral and postgres by one-line installer. Does not cover changes to Vagrant, docker or packages

Closes #516

@amanda11
Copy link
Contributor Author

amanda11 commented Jul 31, 2020

Is it ok to remove mistral completely from installer, or if committed would it affect installs of 3.2.0 - so do we need to check on version of st2 being installed?
e.g. install install mistral if:
a) no version specified (as 3.2.0) still current
b) version specified and < 3.3
The reason I ask is that I see EL6 support had to be re-added to the st2_bootstrap file recently.

@amanda11 amanda11 changed the title Remove mistral installer Remove mistral from bash-installer Jul 31, 2020
@LindsayHill
Copy link
Contributor

@amanda11 when you run curl -sSL https://stackstorm.com/packages/install.sh, that script then pulls the ST2 version branch version of the installer script. It is set to v3.2 right now, and when we release v3.3 it will pull the v3.3 version.

But if you specify an old version, it will pull that old version. So we should be fine with just removing mistral from the master version here, and anyone that deliberately passes an older version flag to the installer should still get an installer script that installs mistral

Copy link
Contributor

@blag blag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like one more set of eyes on this, but this LGTM.

# nginx (80, 443), mongodb (27017), rabbitmq (4369, 5672, 25672), postgresql (5432) and st2 (9100-9102).
# nginx (80, 443), mongodb (27017), rabbitmq (4369, 5672, 25672), and st2 (9100-9102).

declare -a ports=("80" "443" "4369" "5432" "5672" "9100" "9101" "9102" "25672" "27017")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@arm4b arm4b added this to the 3.3.0 milestone Aug 3, 2020
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Looking closer, we want to merge this PR after removing mistral from the e2e tests, otherwise st2cicd jobs will fail on mistral checks.

It's very helpful to have these PRs organized and prepared around the Mistral removal big task!

@amanda11
Copy link
Contributor Author

amanda11 commented Aug 3, 2020

@armab st2tests PR just pushed up (had just finished testing it on the install that had been done using this PR!) - StackStorm/st2tests#190

But I'll also look at the st2ci and st2cd repos...

@blag
Copy link
Contributor

blag commented Aug 4, 2020

PRs StackStorm/st2ci#189 and StackStorm/st2cd#440 are now merged - it should now be clear to merge this.

@blag blag merged commit 06cdc23 into StackStorm:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WARNING mistralclient.auth.keystone [-] You must either provide a valid token or a password (api_key) and a user.

4 participants