-
-
Notifications
You must be signed in to change notification settings - Fork 62
Remove mistral from bash-installer #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Is it ok to remove mistral completely from installer, or if committed would it affect installs of 3.2.0 - so do we need to check on version of st2 being installed? |
|
@amanda11 when you run But if you specify an old version, it will pull that old version. So we should be fine with just removing mistral from the master version here, and anyone that deliberately passes an older version flag to the installer should still get an installer script that installs mistral |
blag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like one more set of eyes on this, but this LGTM.
| # nginx (80, 443), mongodb (27017), rabbitmq (4369, 5672, 25672), postgresql (5432) and st2 (9100-9102). | ||
| # nginx (80, 443), mongodb (27017), rabbitmq (4369, 5672, 25672), and st2 (9100-9102). | ||
|
|
||
| declare -a ports=("80" "443" "4369" "5432" "5672" "9100" "9101" "9102" "25672" "27017") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Looking closer, we want to merge this PR after removing mistral from the e2e tests, otherwise st2cicd jobs will fail on mistral checks.
It's very helpful to have these PRs organized and prepared around the Mistral removal big task!
|
@armab st2tests PR just pushed up (had just finished testing it on the install that had been done using this PR!) - StackStorm/st2tests#190 But I'll also look at the st2ci and st2cd repos... |
|
PRs StackStorm/st2ci#189 and StackStorm/st2cd#440 are now merged - it should now be clear to merge this. |
Removal of postgres and mistral on all platforms from bash one-line installer.
Addresses scripted installer of StackStorm/st2#4762
Covers removal of installation of mistral and postgres by one-line installer. Does not cover changes to Vagrant, docker or packages
Closes #516