Skip to content

Conversation

@winem
Copy link
Contributor

@winem winem commented Dec 17, 2020

This PR removes all references to st2resultstracker in the package specs and service definitions as well as the corresponding service file.

closes #668

@winem
Copy link
Contributor Author

winem commented Dec 17, 2020

The workflow fails because st2ctl still checks the state of the st2resultstracker and can't find it any more.

See https://github.com/StackStorm/st2/blob/746ae505e77126af6b7473a91eb1e98614a67568/st2common/bin/st2ctl#L17

The corresponding issue to be solved first: StackStorm/st2#5070

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thanks! 👍

Once the the CI is green (st2ctl) we're good to merge this.

@winem
Copy link
Contributor Author

winem commented Dec 18, 2020

Now there is a circular dependency between this PR and StackStorm/st2#5108

Agreed with @blag to keep this PR as it is and merge both PRs on monday. The Exchange pack CI builds do have a higher priority and we want them to succeed over the weekend.

See https://stackstorm-community.slack.com/archives/CSBELJ78A/p1608330230290400

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only issue I found based on StackStorm/st2#5108 build is that Makefile still includes resulstracker and needs a change, see: https://github.com/StackStorm/st2-packages/blob/master/packages/st2/Makefile#L83-L84

@arm4b arm4b requested a review from a team December 21, 2020 14:59
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is happy now! 👍

Thanks for the contribution, merging.

@arm4b arm4b merged commit 72e5d8c into StackStorm:master Dec 24, 2020
@arm4b
Copy link
Member

arm4b commented Dec 26, 2020

@winem Following this PR change, we'll need a fix in Ansible-st2 repository (https://github.com/stackstorm/ansible-st2) which started to fail because it included the st2resultstracker in the list of services.
Could you please submit a small PR for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the st2resultstracker service from packaging

2 participants