-
-
Notifications
You must be signed in to change notification settings - Fork 62
Remove st2 resultstracker #683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove st2 resultstracker #683
Conversation
|
The workflow fails because st2ctl still checks the state of the st2resultstracker and can't find it any more. The corresponding issue to be solved first: StackStorm/st2#5070 |
arm4b
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Thanks! 👍
Once the the CI is green (st2ctl) we're good to merge this.
|
Now there is a circular dependency between this PR and StackStorm/st2#5108 Agreed with @blag to keep this PR as it is and merge both PRs on monday. The Exchange pack CI builds do have a higher priority and we want them to succeed over the weekend. See https://stackstorm-community.slack.com/archives/CSBELJ78A/p1608330230290400 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only issue I found based on StackStorm/st2#5108 build is that Makefile still includes resulstracker and needs a change, see: https://github.com/StackStorm/st2-packages/blob/master/packages/st2/Makefile#L83-L84
arm4b
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is happy now! 👍
Thanks for the contribution, merging.
|
@winem Following this PR change, we'll need a fix in Ansible-st2 repository (https://github.com/stackstorm/ansible-st2) which started to fail because it included the |
This PR removes all references to st2resultstracker in the package specs and service definitions as well as the corresponding service file.
closes #668