Don't ask the user to continue with the deadsnakes repo and just mention the cmd line flag #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion the proper flag instead
Contributor
|
@armab I'd like your input/review on this please. |
arm4b
approved these changes
Feb 21, 2021
Member
arm4b
left a comment
arm4b
left a comment
There was a problem hiding this comment.
I'm good with the change here, makes it easier considering edge cases with y/n interactive input in different environments.
Member
|
@blag Up to you to merge when you see it's good timing. |
Contributor
|
Will merge this when I can, hopefully tonight or tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the ability to confirm or deny the installation of python3.6 from the deadsnake repositories on Ubuntu 16.04. Instead it just mentions the corresponding command line flag.
To me, this pragmatic approach to address #688 is fine since users who want to use python3.6 from the unsupported repositories should really know what they do and can just run the script(s) again with the --u16-add-insecure-py3-ppa flag or add the necessary flag to their automation.
!close #688