Skip to content

Conversation

@amanda11
Copy link
Contributor

@amanda11 amanda11 commented Jun 3, 2021

No description provided.

@amanda11
Copy link
Contributor Author

amanda11 commented Jun 3, 2021

Removed xenial. It is still mentioned in st2_bootstrap.sh as I believe that is global across versions, and so we can't remove it, as it would prevent installation of 3.4 on xenial.

Copy link
Contributor

@blag blag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@blag blag requested a review from arm4b June 3, 2021 17:32
@amanda11 amanda11 added the OS support Support/issues/PRs on a specific OS label Jun 3, 2021
@amanda11 amanda11 added this to the 3.5.0 milestone Jun 3, 2021

# Python 3.6 package is not available in Ubuntu Xenial
# Installer can add it via 3rd party PPA based on user agreement
if [[ "$SUBTYPE" = 'xenial' ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could leave this if here and just print an error that Xenial is not supported since v3.5.0 in case someone still tries to run new installer script on Xenial.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on this comment... @Kami @armab @blag

I don't mind either way - but we'd have to put quite a few different - if "xenial" do this checks back in. Plus the 3.5 and "unstable" xenial packages are no-longer built daily - so what they'd get is an old version anyway.

As I understand the install process then if they install 3.4 xenial they will get the "master" st2_bootstrap - but they'd get the st2bootstrap-deb.sh from the 3.4 branch - and so would have all the stuff there.

So to me, it's safer to just remove the ifs, and say that we only support bionic/focal etc.

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@amanda11 amanda11 merged commit 2c4e3b6 into master Jun 7, 2021
@amanda11 amanda11 deleted the remove_xenial branch June 7, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OS support Support/issues/PRs on a specific OS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants