-
-
Notifications
You must be signed in to change notification settings - Fork 62
Remove xenial #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove xenial #704
Conversation
|
Removed xenial. It is still mentioned in st2_bootstrap.sh as I believe that is global across versions, and so we can't remove it, as it would prevent installation of 3.4 on xenial. |
blag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
|
||
| # Python 3.6 package is not available in Ubuntu Xenial | ||
| # Installer can add it via 3rd party PPA based on user agreement | ||
| if [[ "$SUBTYPE" = 'xenial' ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could leave this if here and just print an error that Xenial is not supported since v3.5.0 in case someone still tries to run new installer script on Xenial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on this comment... @Kami @armab @blag
I don't mind either way - but we'd have to put quite a few different - if "xenial" do this checks back in. Plus the 3.5 and "unstable" xenial packages are no-longer built daily - so what they'd get is an old version anyway.
As I understand the install process then if they install 3.4 xenial they will get the "master" st2_bootstrap - but they'd get the st2bootstrap-deb.sh from the 3.4 branch - and so would have all the stuff there.
So to me, it's safer to just remove the ifs, and say that we only support bionic/focal etc.
arm4b
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
No description provided.