st2bootstrap generic template #753
Conversation
cognifloyd
left a comment
cognifloyd
left a comment
There was a problem hiding this comment.
I finally finished reviewing this. I've got some questions and suggested changes.
nzlosh
force-pushed
the
generic_template
branch
2 times, most recently
from
e9b3ec8 to
e707cd6
Compare
nzlosh
force-pushed
the
generic_template
branch
2 times, most recently
from
7636d76 to
52ad4e8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
nzlosh
force-pushed
the
generic_template
branch
3 times, most recently
from
536cc7e to
fc005f9
Compare
cognifloyd
left a comment
cognifloyd
left a comment
There was a problem hiding this comment.
This is so close! And it is so much easier to follow the logic of these templates, minimizing the duplication from the old method.
Co-authored-by: Jacob Floyd <cognifloyd@gmail.com>
cognifloyd
left a comment
cognifloyd
left a comment
There was a problem hiding this comment.
Woohoo. The only question left is about that packaging bug and you mentioned adding a comment about the ASCII logo. In any case I'm satisfied. This looks great!
| "nodejs-${NODE_VERSION}-key" \ | ||
| "https://rpm.nodesource.com/gpgkey/ns-operations-public.key" | ||
|
|
||
| {#- repository jinja template enables repo_gpgcheck which breaks on nodejs 20.x #} |
|
@cognifloyd If you're OK with circling back to the packaging |
Yup. Sounds good. Merge! |
3 participants
This PR rewrites the st2bootstrap script generation process to use jinja templates. A datafile is used to define the set of supported Linux distributions. Jinja templates are defined by functionality, e.g. a mongodb template, redis template, systems template etc to give modularity to the shell script.
Documentation describing how the template and scripts are structured in readme-install-script.md
The re-write is fundamental to addressing package build / test and publish failures in the st2 ci/cd. It has been failing for the last year due to lack of maintenance to the st2bootstrap script.