No validation performed to check parameters for a trigger type match what is defined by user

[lakshmi-kannan]

See https://github.com/StackStorm/st2/pull/3398/files#r120671893.

To repro:

Declare a trigger type in sensor YAML like so

---
  class_name: "FileWatchSensor"
  enabled: true
  entry_point: "file_watch_sensor.py"
  description: "Sensor which monitors files for new lines"
  trigger_types:
    -
      name: "file_watch.line"
      pack: "linux"
      description: "Trigger which indicates a new line has been detected"
      # This sensor can be supplied a path to a file to tail via a rule.
      parameters_schema:
        type: "object"
        properties:
          file_path:  # User ``st2`` should have permissions to be able to read this file.
            description: "Path to the file to monitor"
            type: "string"
            required: true
        additionalProperties: false

Now try to register a rule which doesn't confirm to the schema for parameters we defined in sensor YAML like so

---
name: sample_rule_file_watch
pack: "examples"
description: Sample rule custom trigger type - add a file to be watched by file_watch_sensor in linux pack.
enabled: true

trigger:
  parameters:
    iam_messing_up: /tmp/st2_test
  type: linux.file_watch.line

criteria: {}

action:
  parameters:
    cmd: echo "{{trigger}}"
  ref: core.local

You'll see that a trigger is created and rule will register successfully both of which shouldn't happen.

[lakshmi-kannan]

Looks like st2.dev.conf was missing

[system]
validate_trigger_parameters = true

was missing in st2.dev.conf. I enabled that in 0096682.

After I did that, rule registration fails as expected.

2017-06-08 08:31:00,992 INFO [-] ############## Registering rules ########################
2017-06-08 08:31:00,993 INFO [-] =========================================================
2017-06-08 08:31:01,271 WARNING [-] Failed to register rules: Failed to register rule "/opt/stackstorm/packs/examples/rules/sample_rule_file_watch.yaml" from pack "examples": Additional properties are not allowed ('file_paa' was unexpected)

Failed validating u'additionalProperties' in schema:
    {u'additionalProperties': False,
     u'properties': {u'file_path': {u'description': u'Path to the file to monitor',
                                    u'required': True,
                                    u'type': u'string'}},
     u'type': u'object'}

On instance:
    {'file_paa': '/tmp/st2_test'}
Traceback (most recent call last):
  File "./st2common/bin/st2-register-content", line 22, in <module>
    sys.exit(content_loader.main(sys.argv[1:]))
  File "/mnt/src/storm/st2/st2common/st2common/content/bootstrap.py", line 387, in main
    register_content()
  File "/mnt/src/storm/st2/st2common/st2common/content/bootstrap.py", line 339, in register_content
    register_rules()
  File "/mnt/src/storm/st2/st2common/st2common/content/bootstrap.py", line 248, in register_rules
    raise e
ValueError: Failed to register rule "/opt/stackstorm/packs/examples/rules/sample_rule_file_watch.yaml" from pack "examples": Additional properties are not allowed ('file_paa' was unexpected)

Failed validating u'additionalProperties' in schema:
    {u'additionalProperties': False,
     u'properties': {u'file_path': {u'description': u'Path to the file to monitor',
                                    u'required': True,
                                    u'type': u'string'}},
     u'type': u'object'}

On instance:
    {'file_paa': '/tmp/st2_test'}