Validation of trigger payload for a complex trigger is broken.

[lakshmi-kannan]

A complex trigger is a trigger type with parameters.

Logs

2017-06-07 09:25:04,318 140512766650000 INFO file_watch_sensor [-] Sending payload {'file_name': 'st2_test', 'line': u'I am a ttiny little star', 'file_path': '/tmp/st2_test'} for trigger {'uid': u'trigger:linux:827c7b6f-8ab2-46e5-a564-70d512a3dc11:851746484aeb7ece7f72c1e68c2d91a3', 'parameters': {'file_path': '/tmp/st2_test'}, 'name': u'827c7b6f-8ab2-46e5-a564-70d512a3dc11', 'type': u'linux.file_watch.line', 'id': '593828bad9d7ed580ac450e4', 'pack': u'linux'} to sensor_service.

2017-06-07 09:25:04,320 140512766650000 WARNING sensor_wrapper [-] Failed to validate payload ({'file_name': 'st2_test', 'line': u'I am a ttiny little star', 'file_path': '/tmp/st2_test'}) for trigger "{'uid': u'trigger:linux:827c7b6f-8ab2-46e5-a564-70d512a3dc11:851746484aeb7ece7f72c1e68c2d91a3', 'parameters': {'file_path': '/tmp/st2_test'}, 'name': u'827c7b6f-8ab2-46e5-a564-70d512a3dc11', 'type': u'linux.file_watch.line', 'id': '593828bad9d7ed580ac450e4', 'pack': u'linux'}": unhashable type: 'dict'

[lakshmi-kannan]

Apparently, this is "per design". The sensors are not allowed to use "type" and "parameters" but only use "ref" to dispatch a payload. If they did use "type" and "parameters" to refer to a trigger in sensor code, the validation code pukes. This is probably fine because I am with @Kami that dict lookups in mongo are error prone and therefore ref/id/uid lookups are better. I adapted my sensor code and made sure Trigger and TriggerType also contain a ref field 0128377 b738eef. ref field is optional for now for backward compatibility reasons.