Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates
packs_base_pathin the tests config to point to thest2tests/fixtures/directory.This way we can test resource loading and a lot of other things without needing to mock a bunch of stuff.
In addition to that, #1785 adds constraint that the entry point files needs to be located inside the pack. Before this change, a lot of tests violated this constraint causing failures and a lot of pain.
Note 1: This changes are cherry-pick from #1785 since I also need them in the RBAC branch.
Note 2: Eventually, I will move packs to
st2tests/fixtures/packs/directory, but now it's not that time :P