Skip to content

Conversation

@Kami
Copy link
Member

@Kami Kami commented Aug 10, 2015

This pull request updates packs_base_path in the tests config to point to the st2tests/fixtures/ directory.

This way we can test resource loading and a lot of other things without needing to mock a bunch of stuff.

In addition to that, #1785 adds constraint that the entry point files needs to be located inside the pack. Before this change, a lot of tests violated this constraint causing failures and a lot of pain.

Note 1: This changes are cherry-pick from #1785 since I also need them in the RBAC branch.

Note 2: Eventually, I will move packs to st2tests/fixtures/packs/ directory, but now it's not that time :P

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I know this is not the ideal name, but it's a smaller change which fixes the constraint violation mentioned in the PR description.

Eventually, we can move everything to st2tests/fixtures/packs/core/, but this requires more changes.

@lakshmi-kannan
Copy link
Contributor

Eventually, I will move packs to st2tests/fixtures/packs/ directory, but now it's not that time :P

We already have packs in st2tests/resources/. This whole thing needs a rethought around organization.

@Kami
Copy link
Member Author

Kami commented Aug 10, 2015

Yeah, it's a bit all over the place now.

You are more than welcome to do the change :P

@manasdk
Copy link
Contributor

manasdk commented Aug 10, 2015

I had hit a slight variation of this issue when dealing with registration of new content.

#techdebt at this point

@lakshmi-kannan
Copy link
Contributor

Definitely not an ideal name executions.local but if this gets you unblocked, gfi.

@lakshmi-kannan
Copy link
Contributor

You are more than welcome to do the change :P

Dude, I already did some cleanup moving inlined fixtures in test code to what we have right now. So I have high karma in this regard.

@manasdk
Copy link
Contributor

manasdk commented Aug 10, 2015

+1

We will return to this cleanup some other day.

Kami added a commit that referenced this pull request Aug 10, 2015
@Kami Kami merged commit 1f04004 into master Aug 10, 2015
@Kami Kami deleted the fixtures_fixes branch August 10, 2015 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants