Skip to content

Conversation

@Kami
Copy link
Member

@Kami Kami commented Nov 11, 2016

With new pack management code, .gitinfo file has been deprecated (it's not used anymore) and the actual pack directories are checked out git repository so this file and action is not needed anymore.

If user wants to see which version is installed or similar, they can use existing pack get CLI command. In the future, if need arises, we can also add more information to the pack get command output (e.g. currently checked out git revision, etc.).

Kami added 2 commits November 11, 2016 15:55
.gitinfo file has been deprecated since the pack directories are now actual
checked out git repositories so this action and file is not needed anymore.
@emedvedev
Copy link
Contributor

I'll change it in #2982.

@codecov-io
Copy link

codecov-io commented Nov 11, 2016

Current coverage is 76.63% (diff: 100%)

Merging #3019 into master will increase coverage by 0.11%

@@             master      #3019   diff @@
==========================================
  Files           428        428          
  Lines         21891      21891          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          16750      16774    +24   
+ Misses         5141       5117    -24   
  Partials          0          0          

Powered by Codecov. Last update d7d2ca4...fd7ec7d

@Kami
Copy link
Member Author

Kami commented Nov 11, 2016

@emedvedev Works for me.

On a related note - we could also leave it there for backward compatibility reasons for a while, but we probably want users to migrate to the new system so getting rid of it right now is not a bad idea.

What's our plan for that PR - do we plan to merge it soon and include it in v2.1?

@emedvedev
Copy link
Contributor

Yeah, I'm planning to get to it soon and have it ready for 2.1, and then I'll comb through the st2contrib packs using the old packs actions (like github/bitbucket rules), and change or disable those rules in their Exchange versions.

@emedvedev
Copy link
Contributor

So the backward compatibility here is achieved by the fact that old st2, having the old packs pack, will get packs from st2contrib (and packs there will reference the old syntax), and new st2 will use newer versions from Exchange, that will reference new pack commands.

@lakshmi-kannan
Copy link
Contributor

Nice. We should capture this deprecation in the blog for new pack management

@Kami Kami merged commit b79f68a into master Nov 14, 2016
@Kami Kami deleted the remove_packs_info_action branch November 14, 2016 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants