Adding support for `st2 login` and `st2 whoami` commands #3123

Mierdin · 2016-12-16T01:39:15Z

Overview

This PR introduces a new st2 login command to the StackStorm client. This command is similar to st2 auth, as it does generate a user token, but it also modifies ~/.st2/config and adds a token file to the ~/.st2/config directory. Further st2 commands will use the new username/token combination that was written to disk.

This is in response to #3110, where a user asked if there was a more friendly way of specifying the current user (i.e. without explicitly modifying configuration files or setting environment variables). This command is simply an alternative to those options.

Initially, I considered adding a flag to st2 auth that caches the token in ~/.st2/token-<username> but realized that ~/st2/config would also need to be modified to specify the "current" user. This seemed like a bit too much functionality to have in a single "flag" off of st2 auth, so I decided a separate command was ideal, and more self-explanatory.

By default, this command will write only the username to the configuration, for security purposes (not needed if a token file is present). The user can use the -w option to override this default and write the password into the config file as well.

Note, an st2docs PR will follow this, to document the new command. I just wanted to make sure the approach was valid before I started updating docs.

Example

Here's the new command in action. Note that the configuration file is updated and only the relevant section ("credentials") is written to - the rest is preserved.

(virtualenv)vagrant@st2dev:~/st2$ ll ~/.st2
total 12
drwxrwxr-x 2 vagrant vagrant 4096 Dec 16 17:42 ./
drwxr-xr-x 9 vagrant vagrant 4096 Dec 16 17:42 ../
-rw-rw-r-- 1 vagrant vagrant   40 Dec 16 17:42 config
(virtualenv)vagrant@st2dev:~/st2$ cat ~/.st2/config
[extrasection]
foo1 = bar1
foo2 = bar2

(virtualenv)vagrant@st2dev:~/st2$ st2 login st2admin --password Password1!
Logged in as st2admin
(virtualenv)vagrant@st2dev:~/st2$ cat ~/.st2/config
[extrasection]
foo1 = bar1
foo2 = bar2

[credentials]
username = st2admin

(virtualenv)vagrant@st2dev:~/st2$ cat ~/.st2/token-st2admin
{"expire_timestamp": 1481996584, "token": "a89b4a5fcc0542bcac48d3d9ef67c8c9"}(virtualenv)vagrant@st2dev:~/st2$

On the other hand, a failed login attempt will do nothing:

(virtualenv)vagrant@st2dev:~/st2$ ll ~/.st2/
total 12
drwxrwxr-x 2 vagrant vagrant 4096 Dec 16 17:45 ./
drwxr-xr-x 9 vagrant vagrant 4096 Dec 16 17:45 ../
-rw-rw-r-- 1 vagrant vagrant   40 Dec 16 17:45 config
(virtualenv)vagrant@st2dev:~/st2$ cat ~/.st2/config
[extrasection]
foo1 = bar1
foo2 = bar2

(virtualenv)vagrant@st2dev:~/st2$ st2 login st2admin --password wrongpassword
Failed to log in as st2admin
(virtualenv)vagrant@st2dev:~/st2$ ll ~/.st2/
total 12
drwxrwxr-x 2 vagrant vagrant 4096 Dec 16 17:45 ./
drwxr-xr-x 9 vagrant vagrant 4096 Dec 16 17:45 ../
-rw-rw-r-- 1 vagrant vagrant   40 Dec 16 17:45 config
(virtualenv)vagrant@st2dev:~/st2$ cat ~/.st2/config
[extrasection]
foo1 = bar1
foo2 = bar2

StackStorm documentation has been updated in StackStorm/st2docs#380

UPDATE: Based on some of the review comments, I've added a few tasks for myself:

Add st2 whoami command (thanks for idea @Kami)
Address logging configuration brought up in Adding support for st2 login and st2 whoami commands #3123 (comment)
Update changelog
It's been a while since I looked at this PR - after all the above has been done, need to go through a full end-to-end test and ensure that everything shown in the examples above still works, and also verify that it still handles minor issues like ~/.st2/ not existing, etc.
Documentation tasks. Make sure the descriptions between login and auth commands are sufficiently distinct. Also at least open a st2docs PR and link here

Closes #3110

Signed-off-by: Matt Oswalt <oswaltm@brocade.com>

bigmstone

Looking good. I have a few questions/comments. Also what do you do in the event that the ~/.st2 folder doesn't exist? I'm of the opinion this tool should create it.

bigmstone · 2016-12-16T04:27:04Z

st2client/st2client/commands/auth.py

+        cli._cache_auth_token(token_obj=manager)
+
+        # Update existing configuration with new credentials
+        config_file = "%s/.st2/config" % expanduser("~")


Should use os.path.join or expanduser('~.st2/config') here.

Done (03fb3f6).

bigmstone · 2016-12-16T04:27:25Z

st2client/st2client/commands/auth.py

+        # Update existing configuration with new credentials
+        config_file = "%s/.st2/config" % expanduser("~")
+        config = ConfigParser()
+        config.read(config_file)


What happens if this fails?

No exception is raised, just an empty list is returned.

(Pdb) config.read("/tmp/foodoesntexist.txt") []

This just means there wasn't a file there to populate the config object.

If I run this with the real code, and the config file already exists, you see this:

(Pdb) config.read(config_file) ['/home/vagrant/.st2/config']

Either way, we're always overwriting the two parameters in the "credentials" section, and writing it to disk.

bigmstone · 2016-12-16T04:27:58Z

st2client/st2client/commands/auth.py

+            "username": args.username,
+            "password": args.password
+        }
+        with open(config_file, "w") as cfg_file_out:


Should be w+ to create file if it doesn't exist.

My understanding is that w will still create the file; w+ is used if you want to also read from the file, which in this case I don't care about.

Yep, my mistake.

Signed-off-by: Matt Oswalt <oswaltm@brocade.com>

Mierdin · 2016-12-16T07:14:14Z

@bigmstone:

Also what do you do in the event that the ~/.st2 folder doesn't exist? I'm of the opinion this tool should create it.

The _cache_auth_token method already has lots of checks like this, and I am doing that first, so if that has an error, the rest of the code won't run; if it doesn't, everything should exist.

You think this still warrants more checks within this function, or is that sufficient?

codecov-io · 2016-12-16T07:16:38Z

Codecov Report

Merging #3123 into master will not impact coverage by -<.01%.

@@            Coverage Diff             @@
##           master    #3123      +/-   ##
==========================================
- Coverage   77.65%   77.65%   -<.01%     
==========================================
  Files         433      432       -1     
  Lines       22323    22390      +67     
==========================================
+ Hits        17334    17385      +51     
- Misses       4989     5005      +16

Impacted Files	Coverage Δ
st2client/st2client/base.py	`72.22% <100%> (+10.29%)`	✅
st2client/st2client/shell.py	`86.99% <100%> (+1.87%)`	✅
st2client/st2client/commands/auth.py	`68.13% <82.61%> (+8.84%)`	✅
...ctions/st2actions/resultstracker/resultstracker.py	`72.22% <ø> (-15.28%)`	❌
st2common/st2common/query/base.py	`70.23% <ø> (-10.97%)`	❌
st2exporter/st2exporter/worker.py	`58.82% <ø> (-4.71%)`	❌
st2common/st2common/services/triggerwatcher.py	`87.32% <ø> (-2.82%)`	❌
...common/st2common/validators/workflow/mistral/v2.py	`97.96% <ø> (-2.04%)`	❌
st2common/st2common/bootstrap/aliasesregistrar.py	`63% <ø> (-2%)`	❌
st2api/st2api/controllers/v1/packs.py	`90.12% <ø> (-1.85%)`	❌
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 200efeb...369978e. Read the comment docs.

bigmstone · 2016-12-16T16:24:26Z

@Mierdin Looked over _cache_auth_token. 👍

bigmstone

Once you get the linting stuff fixed then you should be 👍. Might want to get someone else to offer their +1 on direction here, too. I personally like the st2 login UX but others might have a different opinion.

Signed-off-by: Matt Oswalt <oswaltm@brocade.com>

Mierdin · 2016-12-16T18:55:33Z

@bigmstone wanna take another quick look? Lots of changes in eb3aedc so maybe you might want to take a peek again?

arm4b · 2016-12-16T19:38:56Z

st2client/st2client/commands/auth.py

+        cli._cache_auth_token(token_obj=manager)
+
+        # Update existing configuration with new credentials
+        config_file = expanduser('~/.st2/config')


There is probably constant somewhere to store the ~/.st2/config default value.

Additionally, here might be edge cases:
what if env ST2_CONFIG_FILE or --config-file= flag is provided? See the docs: https://docs.stackstorm.com/reference/cli.html?highlight=cli%20authentication#configuration-file

I think we should support that for consistency.

This is a good idea, and I used the function _get_config_file_path in BaseCLI to ensure this consistency. Implemented in 683cb4d

This is how it works now (note if the --config option is omitted, that still works and writes to the default location:

(virtualenv)vagrant@st2dev:~/st2/st2client$ st2 --config /tmp/st2config login st2admin --password Password1! Logged in as st2admin (virtualenv)vagrant@st2dev:~/st2/st2client$ cat /tmp/st2config [credentials] username = st2admin password = notarealpassword

arm4b · 2016-12-16T19:48:00Z

st2client/st2client/commands/auth.py

+        # option is provided, in which case we'll write the real password.
+        config['credentials'] = {
+            "username": args.username,
+            "password": args.password if args.write_password else "notarealpassword"


Writing notarealpassword to conf file looks really really strange

What else should I write? I originally tried omitting the field altogether, but it seems that other st2 commands actually require this field, yet don't use it. Writing an obviously fake password to this field seemed like the simplest approach.

arm4b · 2016-12-16T19:49:05Z

st2client/st2client/commands/auth.py

+        }
+
+        with open(config_file, "w") as cfg_file_out:
+            config.write(cfg_file_out)


What if correct credentials already exist in the file. Do we overwrite them with "fake password"?
If so, looks like "regression", no?

I don't think so, the whole point of st2 login is to change this configuration, so the user should expect it to get overwritten with whatever they put into the args or getpass

arm4b · 2016-12-16T19:58:58Z

If ~/.st2 directory doesn't exist, will it be created by st2 login?

We create that dir via curl | bash script, but it's not single point of truth.
People can install StackStorm with configuration management or manually via apt-get/yum install.

For me, st2 login -w could be useful as a way to run it once after clean st2 installation to store the password. See example: StackStorm/chef-stackstorm#41

Additionally, we could replace this bashery: https://github.com/StackStorm/st2-packages/blob/master/scripts/st2bootstrap-deb.sh#L219-L259 with new functionality provided in this PR.

Mierdin · 2016-12-16T20:55:34Z

@armab See #3123 (comment) - the method that I'm calling to generate a new token does all kinds of useful checks to make sure the directory is created if it doesn't exist. I am making sure that call is done first, so I know what files/directories will be on the system at that point.

m4dcoder · 2016-12-16T22:17:37Z

I'm going to need more clarification from the team here. I looked at the original request. Wouldn't writing/caching the token be sufficient to meet the requirement? How come we are also rewriting the client config and saving the client credential in the config file. That seems insecure and not obvious to the user that their credential will be written to disk.

Mierdin · 2016-12-16T22:24:56Z

@m4dcoder the reason I'm modifying the config is all about instructing other st2 commands which token file to use, via the username. Tokens are cached by username (i.e. ~/.st2/token-st2admin), and my understanding is that the client uses the username in the configuration to determine which token file to reference (helpful when there are multiple).

So, st2 login modifies the configuration by writing the username specified via args. By doing this, other st2 commands know which token file to read to get the token.

Note also by default it writes a dummy/fake password to the config file. Other st2 commands apparently require that this field is present in the config (I tested without), but the field is not used if the token file is found, so the password doesn't need to be correct.

The user request was all about being able to quick switch between users, and this accomplishes this in the most secure way I know how, and doesn't rely on being able to modify environment variables in the calling shell (which you can't do in Python anyways). The config file in this case just acts as a pointer to which token file to use at a given time.

Hope that helps clear things up

m4dcoder · 2016-12-16T22:27:41Z

Can you figure out why the password is needed (even a fake password) in the config file? I prefer we fix this and don't write a fake password. It's just confusing code wise and users who is looking at the config will question that anyway.

This allows the user to specify a different location for the config file using the already-existing "--config" argument Signed-off-by: Matt Oswalt <oswaltm@brocade.com>

Mierdin · 2016-12-16T22:51:44Z

I agree - will hunt that down next.

Mierdin · 2016-12-16T22:56:15Z

@m4dcoder It seems I was mistaken about the password field. I must have lost track of my steps during initial testing; I can perform queries without the password field in the config:

(virtualenv)vagrant@st2dev:~/st2/st2client$ cat ~/.st2/config
[extrasection]
foo1 = bar1
foo2 = bar2

[credentials]
username = st2admin

(virtualenv)vagrant@st2dev:~/st2/st2client$ cat ~/.st2/token-st2admin
{"expire_timestamp": 1482014621, "token": "ee46b13293b345c4a9f7bcd955854b3e"}
(virtualenv)vagrant@st2dev:~/st2/st2client$ st2 execution list
+----+------------+--------------+--------+-----------------+---------------+
| id | action.ref | context.user | status | start_timestamp | end_timestamp |
+----+------------+--------------+--------+-----------------+---------------+
+----+------------+--------------+--------+-----------------+---------------+

In the next few minutes I'll push another commit that removes the password functionality from this patch.

Signed-off-by: Matt Oswalt <oswaltm@brocade.com>

Mierdin · 2016-12-17T01:19:30Z

@armab @m4dcoder I have made the requested changes, can I get another review at your convenience? Thanks and have a great weekend!

m4dcoder · 2016-12-20T01:55:01Z

st2client/st2client/commands/auth.py

+            config_file = cli._get_config_file_path(args)
+        except ValueError:
+            # config file not found in args or in env, defaulting
+            config_file = expanduser('~/.st2/config')


Can you use os.path.expanduser instead and import os above? Also, can you use the constants at https://github.com/StackStorm/st2/blob/master/st2client/st2client/config_parser.py#L36 instead of duplicating and hard coding the path value here?

Fixed in: 9ae4d07

m4dcoder · 2016-12-20T02:06:14Z

st2client/tests/unit/test_auth.py

+                "args": ['--config', '/tmp/st2config', 'login', 'st2admin', '-w'],
+                "expected_username": 'st2admin'
+            }
+        ]


Can you separate into different test methods especially that you've additional things to test for each test case below?

I can split it up; the reason I did it this way was to save a little bit of line count considering that the tests cases have a lot in common. Would result in a lot of redundant test code if I split it up

Yeah, i rather you duplicate here to keep the tests clear. And you can always refactor into private methods for obvious reduction.

Okay I split up these tests and added a function _login_common_assertions to save a little bit of linecount on common things between the unit tests. Committed in d45b9af

arm4b · 2016-12-21T13:17:10Z

st2client/st2client/commands/auth.py

+            config['credentials'] = {}
+        config['credentials']['username'] = args.username
+        if args.write_password:
+            config['credentials']['password'] = args.password


arm4b

Overall logic looks much more expected and cleaner to me 👍

@Kami and @m4dcoder might have better idea about the core internals.

arm4b · 2016-12-21T13:31:57Z

st2client/st2client/commands/auth.py

+        self.parser.add_argument('-l', '--ttl', type=int, dest='ttl', default=None,
+                                 help='The life span of the token in seconds. '
+                                      'Max TTL configured by the admin supersedes this.')
+        self.parser.add_argument('-w', '--write-real-password', action='store_true', default=False,


Since we removed "fake" password logic, "--write_real_password" naming looks a bit strange now.

Maybe it could be better to rename this flag to --save-password or --write-password or any other analog?

Additionally, don't forget to update Pull Request description (first message) with new syntax/logic, because we don't save fake password: notarealpassword anymore

Updated the description, and changed the argument in 7a2ce39

Signed-off-by: Matt Oswalt <oswaltm@brocade.com>

Mierdin · 2017-02-03T23:15:57Z

@Kami Okay - introduced the st2 whoami command in 5f87719, would love to hear your thoughts on the implementation

dzimine · 2017-02-04T00:22:30Z

st2client/st2client/commands/auth.py

+            config.add_section('credentials')
+            config['credentials'] = {}
+        config['credentials']['username'] = args.username
+        if args.write_password:


scenario: configure .st2/config with user1 with password, rewriting it with st2 login user2, user get rewriten, password remains from user1, token expires, user1 no longer works.

Good point - so perhaps I can default to deleting the "password" field (or if --write-password is provided, overwrite)?

@dzimine I took a stab at this in da93e1b - let me know what you think. Seems to work well now for this case

…inger Signed-off-by: Matt Oswalt <oswaltm@brocade.com>

Kami · 2017-02-06T08:50:19Z

CHANGELOG.rst

  put the workflow in a PAUSED state in mistral. (improvement)
 * Add support for evaluating jinja expressions in mistral workflow definition where yaql
  expressions are typically accepted. (improvement)
+# Added support for `st2 login` and `st2 whoami` commands. These add some additional functionality


Minor thing - s/#/*/

Doh! Fixed in 3da2b42

Kami · 2017-02-06T08:54:40Z

st2client/st2client/commands/auth.py

+                raise
+
+
+class WhoamiCommand(resource.ResourceCommand):


Just to confirm - does this follow the same logic as other commands - aka it takes ST2_CONFIG_PATH environment variable, --config-file (or whatever the argument name is), --user, etc. and other things into account when determining the username?

If not, it would be a good idea to do that otherwise it might be confusing to the user.

To clarify, that are the options I had in mind - https://docs.stackstorm.com/reference/cli.html#configuration-file.

@Kami Okay, I tested both the ST2_CONFIG_PATHand--config-file` options, and other than running into this bug (unrelated to this patch) everything seems to work using a totally different config path.

It should be noted that this tool doesn't actually create the configuration file - as with other commands, if the file doesn't exist at the referenced path, it will raise an exception. I did this to be as predictable compared to other st2 commands as possible.

I will push a short note to StackStorm/st2docs#380 to be clear on this

Kami · 2017-02-06T08:58:10Z

Overall, nice work and LGTM 👍

Only "blocker" for me right now which needs some clarification is https://github.com/StackStorm/st2/pull/3123/files#r99538549

Besides that, LGTM.

Signed-off-by: Matt Oswalt <oswaltm@brocade.com>

Kami

LGTM.

(re-ran the build, looks like a temporary upstream issue)

Matt Oswalt added 4 commits December 15, 2016 10:58

Initial work on new 'login' command

ddb85ff

Signed-off-by: Matt Oswalt <oswaltm@brocade.com>

Fixed inappropriate args to auth.LoginCommand, finished functionality

7c97cb5

Signed-off-by: Matt Oswalt <oswaltm@brocade.com>

Added unit test for login command

a8f4f36

Signed-off-by: Matt Oswalt <oswaltm@brocade.com>

Removed erroneous extra line

67a18aa

Signed-off-by: Matt Oswalt <oswaltm@brocade.com>

Mierdin mentioned this pull request Dec 16, 2016

Update CLI authentication to store login #3110

Closed

bigmstone suggested changes Dec 16, 2016

View reviewed changes

Matt Oswalt added 2 commits December 15, 2016 22:35

Removed extra line in test

2d31ff1

Signed-off-by: Matt Oswalt <oswaltm@brocade.com>

Simplified expanduser() call

03fb3f6

Signed-off-by: Matt Oswalt <oswaltm@brocade.com>

Merge branch 'master' of github.com:StackStorm/st2 into st2-login

66fd541

bigmstone approved these changes Dec 16, 2016

View reviewed changes

Matt Oswalt added 2 commits December 16, 2016 10:10

Added -w option, updated unit test

eb3aedc

Signed-off-by: Matt Oswalt <oswaltm@brocade.com>

Properly mocked 'requests' like I should have already done

a050a9f

Signed-off-by: Matt Oswalt <oswaltm@brocade.com>

arm4b suggested changes Dec 16, 2016

View reviewed changes

Used built-in function to determine config location

683cb4d

This allows the user to specify a different location for the config file using the already-existing "--config" argument Signed-off-by: Matt Oswalt <oswaltm@brocade.com>

Matt Oswalt added 2 commits December 16, 2016 16:02

Added mock to config file in shell

7b9dcb6

Signed-off-by: Matt Oswalt <oswaltm@brocade.com>

Writing password field to config file is now totally optional

47529e0

Signed-off-by: Matt Oswalt <oswaltm@brocade.com>

m4dcoder reviewed Dec 20, 2016

View reviewed changes

arm4b reviewed Dec 21, 2016

View reviewed changes

arm4b approved these changes Dec 21, 2016

View reviewed changes

arm4b reviewed Dec 21, 2016

View reviewed changes

Mierdin mentioned this pull request Jan 9, 2017

Install script should setup ~/.st2/config with API key so users don't have to renegotiate auth tokens StackStorm/st2-packages#283

Open

Matt Oswalt added 5 commits February 3, 2017 11:08

Merge branch 'master' into st2-login

51de077

Updated write-password arg to better reflect functionality

7a2ce39

Signed-off-by: Matt Oswalt <oswaltm@brocade.com>

Provided more reasonable fix to previous logging issue

079c89b

Signed-off-by: Matt Oswalt <oswaltm@brocade.com>

Removed commented out old code

8f68d55

Signed-off-by: Matt Oswalt <oswaltm@brocade.com>

Introduce 'st2 whoami' command and tests

5f87719

Updated changelog

3f2c565

Mierdin added WIP feature labels Feb 3, 2017

Mierdin mentioned this pull request Feb 4, 2017

Added references to 'st2 login' and 'st2 whoami' commands StackStorm/st2docs#380

Merged

Mierdin added RFR and removed WIP labels Feb 4, 2017

Mierdin changed the title ~~[WIP] Adding support for st2 login and st2 whoami commands~~ Adding support for st2 login and st2 whoami commands Feb 4, 2017

dzimine reviewed Feb 4, 2017

View reviewed changes

Add logic to remove password field so that previous passwords don't l…

da93e1b

…inger Signed-off-by: Matt Oswalt <oswaltm@brocade.com>

Kami reviewed Feb 6, 2017

View reviewed changes

Changed erroneous hash to star in changelog

3da2b42

Signed-off-by: Matt Oswalt <oswaltm@brocade.com>

Kami approved these changes Feb 7, 2017

View reviewed changes

Merge branch 'master' into st2-login

369978e

Mierdin merged commit 8f8ef7e into StackStorm:master Feb 7, 2017

Mierdin deleted the st2-login branch February 7, 2017 18:08

Mierdin mentioned this pull request Feb 7, 2017

Import configparser from 'six' rather than stdlib #3194

Merged

cognifloyd removed the RFR label Aug 9, 2021

Uh oh!

Adding support for st2 login and st2 whoami commands #3123

Adding support for st2 login and st2 whoami commands #3123

Uh oh!

Conversation

Mierdin commented Dec 16, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Example

Uh oh!

bigmstone left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bigmstone Dec 16, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Mierdin commented Dec 16, 2016

Uh oh!

codecov-io commented Dec 16, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bigmstone commented Dec 16, 2016

Uh oh!

bigmstone left a comment

Choose a reason for hiding this comment

Uh oh!

Mierdin commented Dec 16, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arm4b Dec 16, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arm4b commented Dec 16, 2016

Uh oh!

Mierdin commented Dec 16, 2016

Uh oh!

m4dcoder commented Dec 16, 2016

Uh oh!

Mierdin commented Dec 16, 2016

Uh oh!

m4dcoder commented Dec 16, 2016

Uh oh!

Mierdin commented Dec 16, 2016

Uh oh!

Mierdin commented Dec 16, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mierdin commented Dec 17, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Mierdin Dec 20, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Adding support for `st2 login` and `st2 whoami` commands #3123

Adding support for `st2 login` and `st2 whoami` commands #3123

Mierdin commented Dec 16, 2016 •

edited

Loading

bigmstone Dec 16, 2016 •

edited

Loading

codecov-io commented Dec 16, 2016 •

edited

Loading

arm4b Dec 16, 2016 •

edited

Loading

Mierdin commented Dec 16, 2016 •

edited

Loading

Mierdin Dec 20, 2016 •

edited

Loading

arm4b left a comment •

edited

Loading

arm4b Dec 21, 2016 •

edited

Loading

arm4b Dec 21, 2016 •

edited

Loading

Kami Feb 6, 2017 •

edited

Loading