Fix pylint on runner Python modules #3215
Conversation
because pylint simply silently ignores invalid / inexistent paths.
|
/cc @bigmstone |
Pylint either requires path to a package or a module, passing a path to a directory which is not a package doesn't work and such directory is simply skipped so we need to pass paths to actual Python files / modules.
Codecov Report
@@ Coverage Diff @@
## master #3215 +/- ##
==========================================
+ Coverage 77.64% 77.71% +0.07%
==========================================
Files 433 433
Lines 22414 22414
==========================================
+ Hits 17402 17418 +16
+ Misses 5012 4996 -16
Continue to review full report at Codecov.
|
|
Discovered another issue - f1cf556. |
|
Re line break change - it was needed because of new version of flake8 which improves detection of "2 line breaks after a class and function definition" rule. This rule was there from the beginning, but it didn't correctly detect all the places and new version of flake8 fixes that so we need to update our code. |
|
Since we will be merging #3219 into master, I will go ahead and merge this one as well. This one doesn't affect st2 code, just the build and improves lint detection. |
|
e2e test failures are related to external service being offline. StackStorm/st2cd#243 should hopefully improve the situation. |
I noticed it was broken when I was upgrading pylint as part of #3189.
We passed invalid (in-existent) path to pylint but older versions simply silently ignored that.
For example, it got passed in
contrib/runners/action_chain_runner/contrib/runners/action_chain_runner/instead ofcontrib/runners/action_chain_runner/so files in those directories were not actually pylinted.