-
-
Notifications
You must be signed in to change notification settings - Fork 782
Upgrade dependencies #3372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies #3372
Conversation
|
@Kami looks like you've broken the githubwebhooksensor (https://github.com/StackStorm/GitHubWebhook/blob/master/sensors/webhook_sensor.py). We're now seeing errors like this: Looks to be related to this? urllib3/urllib3#1104 |
|
@LindsayHill @armab one option which I think should also work is for WDYT? |
|
In the worst case, we can revert the upgrade, but recent versions contain various security fixes (https://github.com/request/request/blob/master/CHANGELOG.md) so it would be a good idea to upgrade. |
| pyyaml<4.0,>=3.12 | ||
| rednose | ||
| requests[security]<2.12,>=2.11.1 | ||
| requests[security]<2.14,>=2.13.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest version is 2.14 and even 2.14.1, see changelog: https://github.com/kennethreitz/requests/blob/master/HISTORY.rst
We know that it fixes urllib3/urllib3#1104 (comment) bug
Can we pin to latest instead? That will recover st2cicd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Various dependencies upgrades again to get the latest changes and bug fixes: