Skip to content

Conversation

@Kami
Copy link
Member

@Kami Kami commented Apr 21, 2017

Various dependencies upgrades again to get the latest changes and bug fixes:

  • pyyaml,
  • requests
  • appscheduler
  • gitpython
  • paramiko
  • mongoengine
  • tooz

@Kami Kami changed the title [WIP] Upgrade dependencies Upgrade dependencies Apr 24, 2017
@Kami Kami merged commit 4b1f793 into master May 9, 2017
@Kami Kami deleted the upgrade_deps branch May 9, 2017 12:15
@LindsayHill
Copy link
Contributor

@Kami looks like you've broken the githubwebhooksensor (https://github.com/StackStorm/GitHubWebhook/blob/master/sensors/webhook_sensor.py).

We're now seeing errors like this:

<snip>
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/requests/packages/urllib3/util/ssl_.py", line 324, in ssl_wrap_socket
    return context.wrap_socket(sock, server_hostname=server_hostname)
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/requests/packages/urllib3/contrib/pyopenssl.py", line 438, in wrap_socket
    rd = util.wait_for_read(sock, sock.gettimeout())
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/requests/packages/urllib3/util/wait.py", line 33, in wait_for_read
    return _wait_for_io_events(socks, EVENT_READ, timeout)
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/requests/packages/urllib3/util/wait.py", line 22, in _wait_for_io_events
    with DefaultSelector() as selector:
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/requests/packages/urllib3/util/selectors.py", line 364, in __init__
    self._epoll = select.epoll()
AttributeError: 'module' object has no attribute 'epoll'

Looks to be related to this? urllib3/urllib3#1104

@arm4b
Copy link
Member

arm4b commented May 9, 2017

@Kami The fix looks like using newer patched version of requests >= 2.14.0 or revert to the older one. WDYT?

@Kami
Copy link
Member Author

Kami commented May 10, 2017

@LindsayHill @armab one option which I think should also work is for githubwebhook pack explicitly specify older version of requests in requirements.txt.

WDYT?

@Kami
Copy link
Member Author

Kami commented May 10, 2017

In the worst case, we can revert the upgrade, but recent versions contain various security fixes (https://github.com/request/request/blob/master/CHANGELOG.md) so it would be a good idea to upgrade.

pyyaml<4.0,>=3.12
rednose
requests[security]<2.12,>=2.11.1
requests[security]<2.14,>=2.13.0
Copy link
Member

@arm4b arm4b May 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest version is 2.14 and even 2.14.1, see changelog: https://github.com/kennethreitz/requests/blob/master/HISTORY.rst

We know that it fixes urllib3/urllib3#1104 (comment) bug
Can we pin to latest instead? That will recover st2cicd.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants