Skip to content

Conversation

@bigmstone
Copy link
Contributor

@bigmstone bigmstone commented Jun 13, 2017

Now that deprecation notice is place we need to remove empty config.yaml so warning isn't thrown by default.

CHANGELOG.rst Outdated

Reported by nmlaudy. #3468 #3469
* Removing empty pack config.yaml so warning isn't thrown by default now that deprecation warning
is in place. (fix)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix -> improvement? :trollface:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would also be good to clarify from which pack

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a fix :trollface:
Files missing from the previous PR which introduced that deprecation notice :)

@bigmstone bigmstone merged commit 3b73c7d into master Jun 13, 2017
@bigmstone bigmstone deleted the remove-packs-config branch June 13, 2017 19:27
@arm4b arm4b added this to the 2.3.0 milestone Jun 13, 2017
arm4b pushed a commit that referenced this pull request Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants