-
-
Notifications
You must be signed in to change notification settings - Fork 782
Upgrade various dependencies (v2.4.0) #3538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
a8ee4dc
Upgrade various dependencies to latest stable versions.
Kami e313b31
Update affected code so it works with the latest version of jsonschema.
Kami 64a134e
Update affected code.
Kami 581619f
Also upgrade eventlet.
Kami 1ed102f
Update affected code so it works with latest version of eventlet.
Kami e5ca3f6
Also upgrade paramiko.
Kami 1ec43d2
Revert eventlet change, the removal of select.poll() breaks gitpython
Kami e21ae04
Also upgrade gunicorn and greenlet.
Kami 60a9dde
Also register internal trigger types in bootstrap phase of
Kami e6d7001
Merge branch 'master' into dependencies_upgrade
Kami 4be1a69
Merge branch 'master' into dependencies_upgrade
Kami a19c35e
Update more dependencies.
Kami cdb86a9
Fail if process is none.
Kami 6db3f6e
Re-generate requirements.txt.
Kami af39289
Update affected NoOp tooz coordination driver so it works with latest
Kami File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,40 +1,42 @@ | ||
| # Packages versions fixed for the whole st2 stack | ||
| # Note: greenlet is used by eventlet | ||
| greenlet>=0.4.10,<0.5 | ||
| eventlet>=0.18.4,<0.19 | ||
| gunicorn==19.6.0 | ||
| kombu==3.0.37 | ||
| greenlet==0.4.12 | ||
| # Note: 0.20.0 removed select.poll() on which some of our code and libraries we | ||
| # depend on rely | ||
| eventlet==0.19.0 | ||
| gunicorn==19.7.1 | ||
| kombu==4.0.2 | ||
| # Note: amqp is used by kombu | ||
| amqp==1.4.9 | ||
| amqp==2.2.1 | ||
| oslo.config>=1.12.1,<1.13 | ||
| oslo.utils<3.1.0 | ||
| six==1.10.0 | ||
| pyyaml>=3.12,<4.0 | ||
| requests[security]>=2.14.1,<2.15 | ||
| requests[security]>=2.18.1,<2.19 | ||
| apscheduler==3.3.1 | ||
| gitpython==2.1.3 | ||
| jsonschema>=2.5.0,<2.6 | ||
| mongoengine==0.11.0 | ||
| gitpython==2.1.5 | ||
| jsonschema==2.6.0 | ||
| mongoengine==0.13.0 | ||
| pymongo==3.4.0 | ||
| passlib==1.6.5 | ||
| lockfile>=0.10.2,<0.11 | ||
| python-gnupg==0.3.9 | ||
| jsonpath-rw>=1.3.0 | ||
| pyinotify>=0.9.5,<=0.10 | ||
| semver==2.7.2 | ||
| stevedore>=1.7.0,<1.8 | ||
| paramiko>=2.1.2,<2.2 | ||
| networkx==1.10 | ||
| passlib==1.7.1 | ||
| lockfile==0.12.2 | ||
| python-gnupg==0.4.1 | ||
| jsonpath-rw==1.4.0 | ||
| pyinotify==0.9.6 | ||
| semver==2.7.7 | ||
| stevedore==1.22.0 | ||
| paramiko==2.2.1 | ||
| networkx==1.11 | ||
| python-keyczar==0.716 | ||
| retrying>=1.3,<1.4 | ||
| retrying==1.3.3 | ||
| # Note: We use latest version of virtualenv which uses pip 9.0 | ||
| virtualenv==15.1.0 | ||
| sseclient==0.0.12 | ||
| python-editor==1.0.1 | ||
| prompt-toolkit==1.0.7 | ||
| tooz>=1.55.0,<1.56.0 | ||
| sseclient==0.0.18 | ||
| python-editor==1.0.3 | ||
| prompt-toolkit==1.0.14 | ||
| tooz==1.57.4 | ||
| zake==0.2.2 | ||
| routes==2.3.1 | ||
| flex==6.5.0 | ||
| webob==1.6.0 | ||
| prance==0.5.1 | ||
| routes==2.4.1 | ||
| flex==6.10.0 | ||
| webob==1.7.3 | ||
| prance==0.6.1 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,6 +23,9 @@ | |
|
|
||
| import six | ||
| import requests | ||
| import urllib3 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| from urllib3.exceptions import InsecureRequestWarning | ||
|
|
||
| from st2client import models | ||
| from st2client.config_parser import CLIConfigParser | ||
|
|
@@ -103,7 +106,9 @@ def get_client(self, args, debug=False): | |
| # Silence SSL warnings | ||
| silence_ssl_warnings = rc_config.get('general', {}).get('silence_ssl_warnings', False) | ||
| if silence_ssl_warnings: | ||
| requests.packages.urllib3.disable_warnings() | ||
| # pylint: disable=no-member | ||
| urllib3.disable_warnings(InsecureRequestWarning) | ||
| requests.packages.urllib3.disable_warnings(InsecureRequestWarning) | ||
|
|
||
| # We skip automatic authentication for some commands such as auth | ||
| try: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same change which we reverted before: #3402
It caused the regression for Xenial when 'st2ctl register' failed to register rules on a fresh DB.
If you could investigate and fix the root cause of StackStorm/st2-packages#445 without adding timeouts, - I'm good with that.
Otherwise let's please avoid the same
mongoengineupdate we reverted before.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, plan is to merge it once more testing is done and that issue is resolved.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this change should do it - 60a9dde.
As mentioned in that ticket and discussed on Slack, it seems like there is some weird race and internal trigger types are not registered yet when the script runs.
Registering internal triggers is an idempotent operation we do at every service setup / init phase so doing it again here should have no negative consequences (perhaps just a small performance overhead, but should be fine).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, as we just discussed offline, you are correct, this script shouldn't rely on other services to start first and with this change this is now indeed the case.
In the past we didn't do that, because registering internal trigger types talks to the database and we thought register-content will also be able to run on other servers without st2 and talk to st2 over API, but that's not the case and other functionality of the script also requires to be run from the server where st2 components are running.
And if we ever move it to the API, that's fine as well because then script won't require DB access anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We believe #3542 should resolve the actual underlying race issue so we should be good, but we will still of course do more testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍