Update "st2 apikey load" to update an existing entry if one already exists #3786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exists in the database. This way the command is idempotent and consistent with "st2 key load" command. Keep in mind that update will only work if entries in JSON file contain "id" attribute.
Member
Author
|
It's also worth noting that API operations exposed for datastore exposes get, set, delete while api key one supports get, create, update, delete so the actual CLI code is not 1:1 mapping and we can't simply just call update as we can do in datastore case. |
arm4b
approved these changes
Oct 16, 2017
Member
Author
|
Merged. Will work on st2tests tests separately since there is really no other way to unit test this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug / non-consistent behavior reported in #3748.
It updates
st2 apikey loadcommand so it doesn't throw an updates an existing entry if input file containsidattribute for an item and item already exists on the server.This way behavior is also consistent with
st2 key loadcommand.See https://gist.github.com/Kami/bc7567c6b2b8a62f7680f64921cbf7fc for example output.
Resolves #3748