Back-fill status field on existing RuleEnforcementDB objects #4152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
old / existing object in the database which pre-date status field and have failure_reason field populated.
enykeev
approved these changes
May 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4134 PR added new
statusfield to theRuleEnforcementDBmodel.I intentionally and explicitly didn't backfill data for existing
RuleEnforcementDBobjects in the database, because we still don't have a good data migration framework / code in place (and I don't want to introduce any quick hacks / one offs).@enykeev Was not a fan of old objects having
failure_reasonfield populated, but status set tosucceededso I changed that by backfilling status field for existing objects lazily on retrieval inside the model class constructor.