Use "orchestra_functions" prefix for dynamically loaded orchestra functions #4215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orchestra functions. Using just "functions" means those functions will be copied / installed into "functions" package which could conflict with actual package named functions.
enykeev
approved these changes
Jun 29, 2018
Member
enykeev
left a comment
enykeev
left a comment
There was a problem hiding this comment.
see no problem with renaming to avoid collisions
We also need to fix installer so it won't warn user in the default install.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we use
functionsprefix for dynamically loaded functions in Orchestra.This means orchestra functions are installed in "functions" package. This is bad because "functions" is a generic name and could cause name collisions.
We should either use
orchestra_functions(top level package) ororchestra_runner.functions(if we want to nest / namespace it under orchestra / orchestra_runner package).In this PR, I went with the flat
orchestra_functionsapproach.ubuntu@ip-172-31-2-183:/var/log/st2$ ls -la /opt/stackstorm/st2/lib/python2.7/site-packages/functions total 36 drwxr-xr-x 2 root root 4096 Jun 29 08:28 . drwxr-xr-x 276 root root 20480 Jun 29 08:00 .. -rw-r--r-- 1 root root 0 Jun 29 02:37 __init__.py -rw-r--r-- 1 root root 158 Jun 29 02:37 __init__.pyc -rw-r--r-- 1 root root 1867 Jun 29 08:28 st2kv.py