Dont do coverage for PRs #4266
Dont do coverage for PRs #4266
Conversation
…verage instrumentation
Makefile
Outdated
| # NOTE: We only run coverage on master and version branches and not on pull requests since | ||
| # it has a big performance overhead and is very slow. | ||
| ifeq ($(TRAVIS_PULL_REQUEST),false) | ||
| ENABLE_COVERAGE := yes |
There was a problem hiding this comment.
LGTM, thanks 👍
But as discussed on Slack, I will try to move this step (setting up the environment variable) to travis.yml file.
coverage should be enabled or not and set this variable in .travis.yml.
|
@blag I pushed the environment variable change (1970613) which you didn't implement and we discussed on Slack and the other issue. I will merge it into master and confirm it works correctly. After that, we still need to fix support for coveralls.io reporting which was broken by the PR which refactored coverage stuff (asked discussed on Slack and the other issue). |
|
Confirmed it's working correctly for PRs (https://travis-ci.org/StackStorm/st2/builds/407977396) and for master (https://travis-ci.org/StackStorm/st2/builds/407994065). This also confirmed again that coverage has massive performance overhead ~20 vs ~ 10 minutes so it's correct to only enable it for master and version branch (non pull request) builds. |
Separated out from #4264 to ensure the CircleCI tests pass.