Skip to content

Fix kombu release version #4485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LindsayHill merged 1 commit into from
Jan 2, 2019
Merged

Fix kombu release version #4485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fixed-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ greenlet==0.4.15
# depend on rely
eventlet==0.24.1
gunicorn==19.9.0
kombu==4.2.2
kombu==4.2.2.post1
Copy link
Member

@arm4b arm4b Jan 2, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holy post1!

Copy link
Member

@Kami Kami Jan 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's part of a Python versioning standard - https://www.python.org/dev/peps/pep-0440/#post-releases

I'm fine with it since it's considered a "final" and not a dev / beta release. But yeah, I would definitely prefer them to actually bump a version to 4.2.3 or similar.

# Note: amqp is used by kombu
amqp==2.3.2
# NOTE: Recent version substantially affect the performance and add big import time overhead
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ ipaddr
jinja2
jsonpath-rw==1.4.0
jsonschema==2.6.0
kombu==4.2.2
kombu==4.2.2.post1
lockfile==0.12.2
mock==2.0.0
mongoengine==0.16.3
Expand Down
2 changes: 1 addition & 1 deletion st2common/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ ipaddr
jinja2
jsonpath-rw==1.4.0
jsonschema==2.6.0
kombu==4.2.2
kombu==4.2.2.post1
mongoengine==0.16.3
networkx==1.11
oslo.config<1.13,>=1.12.1
Expand Down